You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/11/21 13:02:44 UTC

Review Request 40574: Return HTTP 403 on REST API authorization failures

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40574/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-14004
    https://issues.apache.org/jira/browse/AMBARI-14004


Repository: ambari


Description
-------

Return HTTP 403 on REST API authorization failures.

# 403 Forbidden
```
{
  "status" : 403,
  "message" : "The authenticated user is not authorized to perform the requested operation"
}
```


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java 706d2be 
  ambari-server/src/main/java/org/apache/ambari/server/api/handlers/DeleteHandler.java 55385a5 
  ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java 1bc4a0f 
  ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java a71ad0c 
  ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java 338d411 
  ambari-server/src/test/java/org/apache/ambari/server/api/handlers/CreateHandlerTest.java 2b50064 
  ambari-server/src/test/java/org/apache/ambari/server/api/handlers/DeleteHandlerTest.java 4f053fd 
  ambari-server/src/test/java/org/apache/ambari/server/api/handlers/QueryCreateHandlerTest.java fa35940 
  ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java c3fc13b 
  ambari-server/src/test/java/org/apache/ambari/server/api/handlers/UpdateHandlerTest.java c88a0ec 

Diff: https://reviews.apache.org/r/40574/diff/


Testing
-------

Manualy testing

# Local test results: PASSED

# Jenkins test results: PENDING


Thanks,

Robert Levas


Re: Review Request 40574: Return HTTP 403 on REST API authorization failures

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40574/#review107494
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Nov. 21, 2015, 12:02 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40574/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2015, 12:02 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14004
>     https://issues.apache.org/jira/browse/AMBARI-14004
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Return HTTP 403 on REST API authorization failures.
> 
> # 403 Forbidden
> ```
> {
>   "status" : 403,
>   "message" : "The authenticated user is not authorized to perform the requested operation"
> }
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java 706d2be 
>   ambari-server/src/main/java/org/apache/ambari/server/api/handlers/DeleteHandler.java 55385a5 
>   ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java 1bc4a0f 
>   ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java a71ad0c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java 338d411 
>   ambari-server/src/test/java/org/apache/ambari/server/api/handlers/CreateHandlerTest.java 2b50064 
>   ambari-server/src/test/java/org/apache/ambari/server/api/handlers/DeleteHandlerTest.java 4f053fd 
>   ambari-server/src/test/java/org/apache/ambari/server/api/handlers/QueryCreateHandlerTest.java fa35940 
>   ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java c3fc13b 
>   ambari-server/src/test/java/org/apache/ambari/server/api/handlers/UpdateHandlerTest.java c88a0ec 
> 
> Diff: https://reviews.apache.org/r/40574/diff/
> 
> 
> Testing
> -------
> 
> Manualy testing
> 
> # Local test results: PASSED
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>