You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/19 08:14:45 UTC
[GitHub] [dubbo] AlbumenJ opened a new pull request #9809: [3.0] reuse some executor services in framework level
AlbumenJ opened a new pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809
## What is the purpose of the change
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809#issuecomment-1073160645
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9809](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4745e58) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7e09abd31340bfd5bcbf64d0979f929f71bb67ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e09abd) will **decrease** coverage by `0.41%`.
> The diff coverage is `88.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9809 +/- ##
============================================
- Coverage 65.60% 65.18% -0.42%
+ Complexity 319 317 -2
============================================
Files 1208 1209 +1
Lines 52545 52554 +9
Branches 7972 7946 -26
============================================
- Hits 34470 34258 -212
- Misses 14329 14538 +209
- Partials 3746 3758 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `69.13% <60.86%> (-12.41%)` | :arrow_down: |
| [...hreadpool/manager/FrameworkExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0ZyYW1ld29ya0V4ZWN1dG9yUmVwb3NpdG9yeS5qYXZh) | `91.52% <91.52%> (ø)` | |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L0Fic3RyYWN0RGlyZWN0b3J5LmphdmE=) | `80.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uster/loadbalance/ShortestResponseLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvU2hvcnRlc3RSZXNwb25zZUxvYWRCYWxhbmNlLmphdmE=) | `91.04% <100.00%> (+0.13%)` | :arrow_up: |
| [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==) | `88.09% <100.00%> (+0.29%)` | :arrow_up: |
| [...ache/dubbo/common/CommonScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29tbW9uU2NvcGVNb2RlbEluaXRpYWxpemVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `72.83% <100.00%> (-0.20%)` | :arrow_down: |
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `66.66% <100.00%> (+0.14%)` | :arrow_up: |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `84.25% <100.00%> (+0.44%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `88.09% <100.00%> (-2.27%)` | :arrow_down: |
| ... and [65 more](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e09abd...4745e58](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809#issuecomment-1073160645
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9809](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4745e58) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7e09abd31340bfd5bcbf64d0979f929f71bb67ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e09abd) will **decrease** coverage by `0.35%`.
> The diff coverage is `88.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9809 +/- ##
============================================
- Coverage 65.60% 65.24% -0.36%
Complexity 319 319
============================================
Files 1208 1209 +1
Lines 52545 52588 +43
Branches 7972 7974 +2
============================================
- Hits 34470 34313 -157
- Misses 14329 14522 +193
- Partials 3746 3753 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `69.13% <60.86%> (-12.41%)` | :arrow_down: |
| [...hreadpool/manager/FrameworkExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0ZyYW1ld29ya0V4ZWN1dG9yUmVwb3NpdG9yeS5qYXZh) | `91.52% <91.52%> (ø)` | |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L0Fic3RyYWN0RGlyZWN0b3J5LmphdmE=) | `80.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uster/loadbalance/ShortestResponseLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvU2hvcnRlc3RSZXNwb25zZUxvYWRCYWxhbmNlLmphdmE=) | `91.04% <100.00%> (+0.13%)` | :arrow_up: |
| [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==) | `88.09% <100.00%> (+0.29%)` | :arrow_up: |
| [...ache/dubbo/common/CommonScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29tbW9uU2NvcGVNb2RlbEluaXRpYWxpemVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `73.08% <100.00%> (+0.05%)` | :arrow_up: |
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `66.66% <100.00%> (+0.14%)` | :arrow_up: |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `84.25% <100.00%> (+0.44%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `90.47% <100.00%> (+0.11%)` | :arrow_up: |
| ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e09abd...4745e58](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809#issuecomment-1073160645
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9809](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4745e58) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7e09abd31340bfd5bcbf64d0979f929f71bb67ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e09abd) will **decrease** coverage by `0.10%`.
> The diff coverage is `88.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9809 +/- ##
============================================
- Coverage 65.60% 65.49% -0.11%
Complexity 319 319
============================================
Files 1208 1209 +1
Lines 52545 52588 +43
Branches 7972 7974 +2
============================================
- Hits 34470 34441 -29
- Misses 14329 14405 +76
+ Partials 3746 3742 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `69.13% <60.86%> (-12.41%)` | :arrow_down: |
| [...hreadpool/manager/FrameworkExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0ZyYW1ld29ya0V4ZWN1dG9yUmVwb3NpdG9yeS5qYXZh) | `91.52% <91.52%> (ø)` | |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L0Fic3RyYWN0RGlyZWN0b3J5LmphdmE=) | `80.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uster/loadbalance/ShortestResponseLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvU2hvcnRlc3RSZXNwb25zZUxvYWRCYWxhbmNlLmphdmE=) | `91.04% <100.00%> (+0.13%)` | :arrow_up: |
| [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==) | `88.09% <100.00%> (+0.29%)` | :arrow_up: |
| [...ache/dubbo/common/CommonScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29tbW9uU2NvcGVNb2RlbEluaXRpYWxpemVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `73.08% <100.00%> (+0.05%)` | :arrow_up: |
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `66.66% <100.00%> (+0.14%)` | :arrow_up: |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `84.25% <100.00%> (+0.44%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `90.47% <100.00%> (+0.11%)` | :arrow_up: |
| ... and [24 more](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e09abd...4745e58](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809#issuecomment-1073160645
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9809](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4745e58) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7e09abd31340bfd5bcbf64d0979f929f71bb67ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e09abd) will **decrease** coverage by `0.22%`.
> The diff coverage is `88.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9809 +/- ##
============================================
- Coverage 65.60% 65.37% -0.23%
Complexity 319 319
============================================
Files 1208 1209 +1
Lines 52545 52588 +43
Branches 7972 7974 +2
============================================
- Hits 34470 34378 -92
- Misses 14329 14456 +127
- Partials 3746 3754 +8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `69.13% <60.86%> (-12.41%)` | :arrow_down: |
| [...hreadpool/manager/FrameworkExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0ZyYW1ld29ya0V4ZWN1dG9yUmVwb3NpdG9yeS5qYXZh) | `91.52% <91.52%> (ø)` | |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L0Fic3RyYWN0RGlyZWN0b3J5LmphdmE=) | `80.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uster/loadbalance/ShortestResponseLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvU2hvcnRlc3RSZXNwb25zZUxvYWRCYWxhbmNlLmphdmE=) | `91.04% <100.00%> (+0.13%)` | :arrow_up: |
| [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==) | `88.09% <100.00%> (+0.29%)` | :arrow_up: |
| [...ache/dubbo/common/CommonScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29tbW9uU2NvcGVNb2RlbEluaXRpYWxpemVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `73.08% <100.00%> (+0.05%)` | :arrow_up: |
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `66.66% <100.00%> (+0.14%)` | :arrow_up: |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `84.25% <100.00%> (+0.44%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `90.47% <100.00%> (+0.11%)` | :arrow_up: |
| ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e09abd...4745e58](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809#issuecomment-1073160645
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9809](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4745e58) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7e09abd31340bfd5bcbf64d0979f929f71bb67ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e09abd) will **decrease** coverage by `0.11%`.
> The diff coverage is `88.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9809 +/- ##
============================================
- Coverage 65.60% 65.48% -0.12%
Complexity 319 319
============================================
Files 1208 1209 +1
Lines 52545 52588 +43
Branches 7972 7974 +2
============================================
- Hits 34470 34439 -31
- Misses 14329 14407 +78
+ Partials 3746 3742 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `69.13% <60.86%> (-12.41%)` | :arrow_down: |
| [...hreadpool/manager/FrameworkExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0ZyYW1ld29ya0V4ZWN1dG9yUmVwb3NpdG9yeS5qYXZh) | `91.52% <91.52%> (ø)` | |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L0Fic3RyYWN0RGlyZWN0b3J5LmphdmE=) | `80.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uster/loadbalance/ShortestResponseLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvU2hvcnRlc3RSZXNwb25zZUxvYWRCYWxhbmNlLmphdmE=) | `91.04% <100.00%> (+0.13%)` | :arrow_up: |
| [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==) | `88.09% <100.00%> (+0.29%)` | :arrow_up: |
| [...ache/dubbo/common/CommonScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29tbW9uU2NvcGVNb2RlbEluaXRpYWxpemVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `73.08% <100.00%> (+0.05%)` | :arrow_up: |
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `66.66% <100.00%> (+0.14%)` | :arrow_up: |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `84.25% <100.00%> (+0.44%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `90.47% <100.00%> (+0.11%)` | :arrow_up: |
| ... and [24 more](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e09abd...4745e58](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9809: [3.0] reuse some executor services in framework level
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9809:
URL: https://github.com/apache/dubbo/pull/9809#issuecomment-1073160645
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9809](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4745e58) into [3.0](https://codecov.io/gh/apache/dubbo/commit/7e09abd31340bfd5bcbf64d0979f929f71bb67ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e09abd) will **decrease** coverage by `0.15%`.
> The diff coverage is `88.42%`.
```diff
@@ Coverage Diff @@
## 3.0 #9809 +/- ##
============================================
- Coverage 65.60% 65.45% -0.16%
Complexity 319 319
============================================
Files 1208 1209 +1
Lines 52545 52588 +43
Branches 7972 7974 +2
============================================
- Hits 34470 34419 -51
- Misses 14329 14423 +94
Partials 3746 3746
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `69.13% <60.86%> (-12.41%)` | :arrow_down: |
| [...hreadpool/manager/FrameworkExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0ZyYW1ld29ya0V4ZWN1dG9yUmVwb3NpdG9yeS5qYXZh) | `91.52% <91.52%> (ø)` | |
| [...dubbo/rpc/cluster/directory/AbstractDirectory.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L0Fic3RyYWN0RGlyZWN0b3J5LmphdmE=) | `80.39% <100.00%> (+0.12%)` | :arrow_up: |
| [...uster/loadbalance/ShortestResponseLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvU2hvcnRlc3RSZXNwb25zZUxvYWRCYWxhbmNlLmphdmE=) | `91.04% <100.00%> (+0.13%)` | :arrow_up: |
| [...bbo/rpc/cluster/support/ForkingClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Gb3JraW5nQ2x1c3Rlckludm9rZXIuamF2YQ==) | `88.09% <100.00%> (+0.29%)` | :arrow_up: |
| [...ache/dubbo/common/CommonScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29tbW9uU2NvcGVNb2RlbEluaXRpYWxpemVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `73.08% <100.00%> (+0.05%)` | :arrow_up: |
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `66.66% <100.00%> (+0.14%)` | :arrow_up: |
| [...che/dubbo/metadata/AbstractServiceNameMapping.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9BYnN0cmFjdFNlcnZpY2VOYW1lTWFwcGluZy5qYXZh) | `84.25% <100.00%> (+0.44%)` | :arrow_up: |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `90.47% <100.00%> (+0.11%)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/dubbo/pull/9809/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e09abd...4745e58](https://codecov.io/gh/apache/dubbo/pull/9809?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org