[GitHub] [hbase] Apache9 commented on a change in pull request #2403: HBASE-24831 : Addendum for source compatibility

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2403:
URL: https://github.com/apache/hbase/pull/2403#discussion_r488650450



##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java
##########
@@ -267,6 +288,15 @@ private void updateCounters() {
     updateCounters(scanMetrics, numRestarts, context, numStale);
   }
 
+  /**
+   * @deprecated since 2.4.0 and 2.3.2, will be removed in 4.0.0
+   *   Use {@link #updateCounters(ScanMetrics, long, TaskAttemptContext, long)} instead.
+   */
+  protected static void updateCounters(ScanMetrics scanMetrics, long numScannerRestarts,

Review comment:
       Ditto.

##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java
##########
@@ -95,6 +96,26 @@ public void restart(byte[] firstRow) throws IOException {
     }
   }
 
+  /**
+   * In new mapreduce APIs, TaskAttemptContext has two getCounter methods
+   * Check if getCounter(String, String) method is available.
+   * @return The getCounter method or null if not available.
+   * @deprecated since 2.4.0 and 2.3.2, will be removed in 4.0.0
+   */
+  protected static Method retrieveGetCounterWithStringsParams(TaskAttemptContext context)

Review comment:
       Please add `@Deprecated` annotation to this method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org