[GitHub] [sling-org-apache-sling-resourcemerger] raducotescu commented on a diff in pull request #10: Fixes for SLING-11774, SLING-11775

["raducotescu (via GitHub)" <gi...@apache.org>]

raducotescu commented on code in PR #10:
URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/10#discussion_r1106986628


##########
src/main/java/org/apache/sling/resourcemerger/impl/MergedResourcePickerWhiteboard.java:
##########
@@ -64,7 +67,11 @@ protected void deactivate() {
     }
 
     @Reference(policy = ReferencePolicy.DYNAMIC, cardinality = ReferenceCardinality.MULTIPLE)
-    public void bindMergedResourcePicker(MergedResourcePicker resourcePicker, Map<String, Object> properties) {
+    public void bindMergedResourcePicker(MergedResourcePicker resourcePicker,

Review Comment:
   I think it had something to do with the change from #8 not being implemented the same way in my initial set of changes. You're right - if I compare the properties map from the service reference with the map parameter of the previous signature they are now identical.
   
   I can revert the commit for SLING-11774 without any problems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org