You are viewing a plain text version of this content. The canonical link for it is here.

Posted to mapreduce-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2014/07/16 20:58:07 UTC

[jira] [Commented] (MAPREDUCE-5971) move the default options for distcp -p to DistCpOptionSwitch

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063917#comment-14063917 ] 

Andrew Wang commented on MAPREDUCE-5971:
----------------------------------------

Hi Charles, thanks for working on this, I took a quick look:

Since we're adding a new "getDefaultValue" to DistCpOptionSwitch, shouldn't we make the handling of default values in CustomParser generic as well? Right now using the default value is still special cased only for PRESERVE_STATUS. Maybe build a map with the default values in CustomParser?

> move the default options for distcp -p to DistCpOptionSwitch
> ------------------------------------------------------------
>
>                 Key: MAPREDUCE-5971
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5971
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: distcp
>    Affects Versions: trunk
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>            Priority: Trivial
>         Attachments: MAPREDUCE-5971.001.patch
>
>
> The default preserve flags for distcp -p are embedded in the OptionsParser code. Refactor to co-locate them with the actual flag initialization.



--
This message was sent by Atlassian JIRA
(v6.2#6252)