You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/05/02 22:16:06 UTC
[jira] [Commented] (HELIX-592) addCluster should respect
overwriteExisitng when adding stateModelDefinations
[ https://issues.apache.org/jira/browse/HELIX-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525454#comment-14525454 ]
ASF GitHub Bot commented on HELIX-592:
--------------------------------------
Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/26#discussion_r29550320
--- Diff: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java ---
@@ -329,8 +329,9 @@ public HelixAdmin getClusterManagementTool() {
return _admin;
}
- public void addStateModelDef(String clusterName, String stateModelDef, StateModelDefinition record) {
--- End diff --
Please do not remove public methods. Instead, call the new method from the old one with a default value.
> addCluster should respect overwriteExisitng when adding stateModelDefinations
> -----------------------------------------------------------------------------
>
> Key: HELIX-592
> URL: https://issues.apache.org/jira/browse/HELIX-592
> Project: Apache Helix
> Issue Type: Bug
> Reporter: Congrui Ji
>
> Currently addCluster in clusterSetup.java ignores the overwriteExisitng parameter while adding stateModelDefinations. This causes exception -StateModelDef already exist. please help fix this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)