You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Kantor <dk...@us.ibm.com> on 2017/02/08 03:26:00 UTC
Review Request 56287: ATLAS-499 Auto update of reverse reference
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-499
https://issues.apache.org/jira/browse/ATLAS-499
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java d9c7feb19cc15c16518682e2211b5cfb025d04f5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 56287: ATLAS-1551 Auto update of reverse reference
in V1 API
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 8:29 p.m.)
Review request for atlas.
Bugs: ATLAS-1551
https://issues.apache.org/jira/browse/ATLAS-1551
Repository: atlas
Description (updated)
-------
ATLAS-1551 auto update of reverse references in V1 API
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java e2bc02871714907af35fd3acbf73b39094b65d72
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 56287: ATLAS-1551 Auto update of reverse reference
in V1 API
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 8:28 p.m.)
Review request for atlas.
Summary (updated)
-----------------
ATLAS-1551 Auto update of reverse reference in V1 API
Bugs: ATLAS-1551
https://issues.apache.org/jira/browse/ATLAS-1551
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java e2bc02871714907af35fd3acbf73b39094b65d72
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 8:28 p.m.)
Review request for atlas.
Changes
-------
Changed bug to ATLAS-1551, which is the sub-task of ATLAS-499 that is specifically tracking the V1 changes.
Bugs: ATLAS-1551
https://issues.apache.org/jira/browse/ATLAS-1551
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java e2bc02871714907af35fd3acbf73b39094b65d72
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by David Radley <da...@uk.ibm.com>.
Hi Dave,
Should I now close the Jira? Or is there some reason to leave it open
(maybe for a release),
all the best, David.
From: David Kantor <dk...@us.ibm.com>
To: David Kantor <dk...@us.ibm.com>, atlas
<de...@atlas.incubator.apache.org>, Jeff Hagelberg <jn...@us.ibm.com>
Date: 09/02/2017 20:44
Subject: Re: Review Request 56287: ATLAS-499 Auto update of reverse
reference
Sent by: David Kantor <no...@reviews.apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 8:43 p.m.)
Review request for atlas.
Changes
-------
Rebased with master
Bugs: ATLAS-499
https://issues.apache.org/jira/browse/ATLAS-499
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
e2bc02871714907af35fd3acbf73b39094b65d72
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java
PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java
PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java
PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java
5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 8:43 p.m.)
Review request for atlas.
Changes
-------
Rebased with master
Bugs: ATLAS-499
https://issues.apache.org/jira/browse/ATLAS-499
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java e2bc02871714907af35fd3acbf73b39094b65d72
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 1 a.m.)
Review request for atlas.
Changes
-------
Address review comment
Bugs: ATLAS-499
https://issues.apache.org/jira/browse/ATLAS-499
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java d9c7feb19cc15c16518682e2211b5cfb025d04f5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by David Kantor <dk...@us.ibm.com>.
> On Feb. 8, 2017, 8:14 p.m., Jeff Hagelberg wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java, line 423
> > <https://reviews.apache.org/r/56287/diff/2/?file=1627188#file1627188line423>
> >
> > Is it safe to remove this check? I'm not sure it is a safe to assume calling ITypedInstance.get(...) will always return something that is non-null.
This check is not needed as it has already been done above. This was pointed out by a code scan a while back and I had already applied this same change on the fork.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/#review164757
-----------------------------------------------------------
On Feb. 9, 2017, 1 a.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56287/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 1 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-499
> https://issues.apache.org/jira/browse/ATLAS-499
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-499 auto update of reverse references in V1 API
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java d9c7feb19cc15c16518682e2211b5cfb025d04f5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
>
> Diff: https://reviews.apache.org/r/56287/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/#review164757
-----------------------------------------------------------
Fix it, then Ship it!
Just a few minor comments.
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
<https://reviews.apache.org/r/56287/#comment236516>
Is it safe to remove this check? I'm not sure it is a safe to assume calling ITypedInstance.get(...) will always return something that is non-null.
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java (line 137)
<https://reviews.apache.org/r/56287/#comment236518>
Please add javadoc for this method.
- Jeff Hagelberg
On Feb. 8, 2017, 3:35 a.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56287/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 3:35 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-499
> https://issues.apache.org/jira/browse/ATLAS-499
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-499 auto update of reverse references in V1 API
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java d9c7feb19cc15c16518682e2211b5cfb025d04f5
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
> typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
>
> Diff: https://reviews.apache.org/r/56287/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 56287: ATLAS-499 Auto update of reverse reference
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56287/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 3:35 a.m.)
Review request for atlas.
Changes
-------
Remove extra whitespace
Bugs: ATLAS-499
https://issues.apache.org/jira/browse/ATLAS-499
Repository: atlas
Description
-------
ATLAS-499 auto update of reverse references in V1 API
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java d9c7feb19cc15c16518682e2211b5cfb025d04f5
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308346034a475c65b7103988d542dd8b1796
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 5c977c147a63106b810f8855f3e7905b4075e165
Diff: https://reviews.apache.org/r/56287/diff/
Testing
-------
Ran all unit and integration tests with no regressions.
Thanks,
David Kantor