You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "zoudan (via GitHub)" <gi...@apache.org> on 2023/04/24 06:58:42 UTC

[GitHub] [calcite] zoudan commented on a diff in pull request #3172: [CALCITE-5670] Assertion error in SemiJoinJoinTransposeRule

zoudan commented on code in PR #3172:
URL: https://github.com/apache/calcite/pull/3172#discussion_r1174856086


##########
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinJoinTransposeRule.java:
##########
@@ -102,16 +101,18 @@ public SemiJoinJoinTransposeRule(RelBuilderFactory relBuilderFactory) {
 
     // determine which operands below the semi-join are the actual
     // Rels that participate in the semi-join
+    final ImmutableIntList leftKeys = semiJoin.analyzeCondition().leftKeys;

Review Comment:
   It is unnecessary to move this line here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org