You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Julien CARSIQUE (JIRA)" <ji...@codehaus.org> on 2009/12/28 19:12:56 UTC

[jira] Issue Comment Edited: (MASSEMBLY-285) regression: duplicate files added to the assembly

    [ http://jira.codehaus.org/browse/MASSEMBLY-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=204300#action_204300 ] 

Julien CARSIQUE edited comment on MASSEMBLY-285 at 12/28/09 12:12 PM:
----------------------------------------------------------------------

There's still a missing behavior which is "replace/update/overwrite" like zip "-u" option.
I need this and I guess it's the most wanted behavior when archiving files already present in a zip, we often want to update/replace the file already archived, not to skip the new one (or preserve the old one).

Please reopen issue as the fix doesn't provide same behavior as what was produced by version 2.1 (overwrite old files with new ones).

For testing, I use the following assembly and expect files in the zip being those from resources_new directory:
<assembly>
  <id>resources-test</id>
  <formats>
    <format>zip</format>
  </formats>
  <includeBaseDirectory>false</includeBaseDirectory>
  <fileSets>
    <fileSet>
      <directory>src/main/resources_old</directory>
      <outputDirectory>/</outputDirectory>
    </fileSet>
    <fileSet>
      <directory>src/main/resources_new</directory>
      <outputDirectory>/</outputDirectory>
    </fileSet>
  </fileSets>
</assembly>

      was (Author: jcarsique):
    There's still a missing behavior which is "replace/update/overwrite" like zip "-u" option.
I need this and I guess it's the most wanted behavior when archiving files already present in a zip, we often want to update/replace the file already archived, not to skip the new one (or preserve the old one).
  
> regression: duplicate files added to the assembly
> -------------------------------------------------
>
>                 Key: MASSEMBLY-285
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-285
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-1
>            Reporter: Brett Porter
>            Assignee: John Casey
>            Priority: Blocker
>             Fix For: 2.2-beta-3
>
>
> I found that it was possible to add a file twice to the assembly through different filesets (a zip file) so that when it extracted it prompted for overwrite.
> It should error out or collapse the entries (as 2.1 did).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira