You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/20 11:15:12 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #4414: Adding public ip to listKubernetesClusterResponse
davidjumani opened a new pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414
## Description
Adding public ip to listKubernetesClusterResponse to make life easier as well as enhance the UI
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712825987
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-717271071
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712982732
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712868730
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712822935
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-717300636
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-717299594
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712779810
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712822256
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-717624314
<b>Trillian test result (tid-3083)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33209 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4414-t3083-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712831089
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#discussion_r509077265
##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##########
@@ -604,6 +608,13 @@ public KubernetesClusterResponse createKubernetesClusterResponse(long kubernetes
response.setEndpoint(kubernetesCluster.getEndpoint());
response.setNetworkId(ntwk.getUuid());
response.setAssociatedNetworkName(ntwk.getName());
+ if (ntwk.getGuestType() == Network.GuestType.Isolated) {
Review comment:
so when SHARED/L2/VPC this needs changing again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-717272033
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712831814
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-717295091
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2281
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712864751
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712981638
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-712779427
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#issuecomment-713231437
<b>Trillian test result (tid-3026)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30246 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4414-t3026-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4414: Adding public ip to listKubernetesClusterResponse
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4414:
URL: https://github.com/apache/cloudstack/pull/4414#discussion_r509108713
##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##########
@@ -604,6 +608,13 @@ public KubernetesClusterResponse createKubernetesClusterResponse(long kubernetes
response.setEndpoint(kubernetesCluster.getEndpoint());
response.setNetworkId(ntwk.getUuid());
response.setAssociatedNetworkName(ntwk.getName());
+ if (ntwk.getGuestType() == Network.GuestType.Isolated) {
Review comment:
There shouldn't be any need. It doesn't support L2 / Shared (since they don't have public IPs) or VPCs as of now, and if support is added, VPC networks are again isolated networks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org