You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/30 19:33:12 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #1924: Allows network monitoring (apps repo) using polling

davids5 opened a new pull request #1924:
URL: https://github.com/apache/incubator-nuttx/pull/1924


   ## Summary
   
   ### Low level Net Monitor Polling 
   Sister PR to ...
     Not all boards have an interrupt line from the phy to the Soc. This commit allows the phy to be polled for
      link status.
   
      This may not work on all MAC/PHY combination that have mutually exclusive link management and operating
      modes. The STM32F7 and LAN8742AI do not have such a  limitation.
   
   ## Impact
   
   None all  configurations have Kconfig knobs. 
   
   ## Testing
   
   PX4 FMUV5X
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1924: Allows network monitoring (apps repo) using polling

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1924:
URL: https://github.com/apache/incubator-nuttx/pull/1924#issuecomment-701924539


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] patacongo commented on pull request #1924: Allows network monitoring (apps repo) using polling

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1924:
URL: https://github.com/apache/incubator-nuttx/pull/1924#issuecomment-701881718


   > 
   > 
   > LGTM. @patacongo do you have more comment?
   
   No, I have nothing to add.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1924: Allows network monitoring (apps repo) using polling

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1924:
URL: https://github.com/apache/incubator-nuttx/pull/1924


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] davids5 commented on pull request #1924: Allows network monitoring (apps repo) using polling

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1924:
URL: https://github.com/apache/incubator-nuttx/pull/1924#issuecomment-701604548


   > @davids5 I think the first two patches are reasonable, could you remove the last one?
   
   @xiaoxiang781216 Done!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org