You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/03/11 15:51:24 UTC
Re: Review Request 44663: Check To Ensure That All Components Are On
The Same Version Before Upgrading
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44663/
-----------------------------------------------------------
(Updated March 11, 2016, 4:51 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.
Summary (updated)
-----------------
Check To Ensure That All Components Are On The Same Version Before Upgrading
Bugs: AMBARI-15374
https://issues.apache.org/jira/browse/AMBARI-15374
Repository: ambari
Description
-------
Before beginning an upgrade, there should be a pre-upgrade check which ensures that all known, versionable components are reporting the same version. If any host component is reporting a version which does not match the current repository version, then a warning should be produced. The warning should provide information on the failed components, the expected version, and the version they are reporting.
Note that this is only for Ambari 2.2.x; Ambari 2.4.0 uses a new workflow for how versions are recorded and stored during upgrade and does not need this.
There are two ways to go about this:
- Compare each service component host version to that of the {{CURRENT}} {{repo_version}}. However, there could be cases where the {{repo_version}} has not been calculated yet.
- Compare each service component host version to each other.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheck.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/44663/diff/
Testing (updated)
-------
Unit tests in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 44663: Check To Ensure That All Components Are On
The Same Version Before Upgrading
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44663/#review123145
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 11, 2016, 9:51 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44663/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 9:51 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15374
> https://issues.apache.org/jira/browse/AMBARI-15374
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Before beginning an upgrade, there should be a pre-upgrade check which ensures that all known, versionable components are reporting the same version. If any host component is reporting a version which does not match the current repository version, then a warning should be produced. The warning should provide information on the failed components, the expected version, and the version they are reporting.
>
> Note that this is only for Ambari 2.2.x; Ambari 2.4.0 uses a new workflow for how versions are recorded and stored during upgrade and does not need this.
>
> There are two ways to go about this:
> - Compare each service component host version to that of the {{CURRENT}} {{repo_version}}. However, there could be cases where the {{repo_version}} has not been calculated yet.
>
> - Compare each service component host version to each other.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44663/diff/
>
>
> Testing
> -------
>
> Unit tests in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44663: Check To Ensure That All Components Are On
The Same Version Before Upgrading
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44663/#review123149
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Березень 11, 2016, 3:36 після полудня, Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44663/
> -----------------------------------------------------------
>
> (Updated Березень 11, 2016, 3:36 після полудня)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15374
> https://issues.apache.org/jira/browse/AMBARI-15374
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Before beginning an upgrade, there should be a pre-upgrade check which ensures that all known, versionable components are reporting the same version. If any host component is reporting a version which does not match the current repository version, then a warning should be produced. The warning should provide information on the failed components, the expected version, and the version they are reporting.
>
> Note that this is only for Ambari 2.2.x; Ambari 2.4.0 uses a new workflow for how versions are recorded and stored during upgrade and does not need this.
>
> There are two ways to go about this:
> - Compare each service component host version to that of the {{CURRENT}} {{repo_version}}. However, there could be cases where the {{repo_version}} has not been calculated yet.
>
> - Compare each service component host version to each other.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheck.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44663/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44663: Check To Ensure That All Components Are On
The Same Version Before Upgrading
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44663/
-----------------------------------------------------------
(Updated March 11, 2016, 5:36 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.
Changes
-------
Minor fixes
Bugs: AMBARI-15374
https://issues.apache.org/jira/browse/AMBARI-15374
Repository: ambari
Description
-------
Before beginning an upgrade, there should be a pre-upgrade check which ensures that all known, versionable components are reporting the same version. If any host component is reporting a version which does not match the current repository version, then a warning should be produced. The warning should provide information on the failed components, the expected version, and the version they are reporting.
Note that this is only for Ambari 2.2.x; Ambari 2.4.0 uses a new workflow for how versions are recorded and stored during upgrade and does not need this.
There are two ways to go about this:
- Compare each service component host version to that of the {{CURRENT}} {{repo_version}}. However, there could be cases where the {{repo_version}} has not been calculated yet.
- Compare each service component host version to each other.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheck.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceComponentHostVersionMatchCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/44663/diff/
Testing (updated)
-------
mvn clean test
Thanks,
Dmitro Lisnichenko