[GitHub] [incubator-iceberg] xiao-chen commented on a change in pull request #144: Delete temporary metadata file when rename fails.

[GitBox <gi...@apache.org>]

xiao-chen commented on a change in pull request #144: Delete temporary metadata file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272313082
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
 ##########
 @@ -152,6 +154,19 @@ public void commit(TableMetadata base, TableMetadata metadata) {
     this.shouldRefresh = true;
   }
 
+  /**
+   * Deletes the file from the file system. Any RuntimeIOException will be swallowed and logged.
+   *
+   * @param tempMetadataFile the file to be deleted.
+   */
+  private void deleteFileNoThrow(final Path tempMetadataFile) {
 
 Review comment:
   Thanks for the review. Updated PR to suppress. Also refactored the rename code to a separate method because I'll need to change the throw line of `CommitFailedException` anyways.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org