You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alexey Neyman <st...@att.net> on 2010/11/15 20:05:10 UTC
Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?
Hi all,
On Wednesday, August 11, 2010 01:09:50 pm C. Michael Pilato wrote:
> On 08/11/2010 03:10 PM, C. Michael Pilato wrote:
> > On 08/10/2010 09:22 PM, Alexey Neyman wrote:
> >> Okay, try again:
> >>
> >> [[[
> >> Fix the type of structures returned in bindings from
> >> svn_fs_paths_changed2().
> >>
> >> * subversion/include/svn_fs.h
> >>
> >> (svn_fs_paths_changed2): Rename the argument from changed_paths_p to
> >> changed_paths_p2, so that it's different from argument to
> >> svn_fs_paths_changed().
> >
> > Minor nit -- I think 'changed_paths2_p' would be a better name. To me, a
> > number at the very end of a parameter name says "differentiator" (as in
> > 'strcmp(str1, str2)') whereas having that '2' closer to the
> > 'changed_paths' name says "version iterator". But like I said, it's a
> > minor nit.
> >
> > Otherwise, +1 on the patch.
>
> Committed with the aforementioned tweaks in r984565. Thanks, Alexey.
Could this patch be picked up in 1.6.14?
Regards,
Alexey.
Re: [PATCH] Bug in svn_fs_paths_changed2() Python bindings?
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 11/15/2010 03:05 PM, Alexey Neyman wrote:
> Hi all,
>
> On Wednesday, August 11, 2010 01:09:50 pm C. Michael Pilato wrote:
>> On 08/11/2010 03:10 PM, C. Michael Pilato wrote:
>>> On 08/10/2010 09:22 PM, Alexey Neyman wrote:
>>>> Okay, try again:
>>>>
>>>> [[[
>>>> Fix the type of structures returned in bindings from
>>>> svn_fs_paths_changed2().
>>>>
>>>> * subversion/include/svn_fs.h
>>>>
>>>> (svn_fs_paths_changed2): Rename the argument from changed_paths_p to
>>>> changed_paths_p2, so that it's different from argument to
>>>> svn_fs_paths_changed().
>>>
>>> Minor nit -- I think 'changed_paths2_p' would be a better name. To me, a
>>> number at the very end of a parameter name says "differentiator" (as in
>>> 'strcmp(str1, str2)') whereas having that '2' closer to the
>>> 'changed_paths' name says "version iterator". But like I said, it's a
>>> minor nit.
>>>
>>> Otherwise, +1 on the patch.
>>
>> Committed with the aforementioned tweaks in r984565. Thanks, Alexey.
>
> Could this patch be picked up in 1.6.14?
>
> Regards,
> Alexey.
I've made the proposal. Now, we just need votes.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand