You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:44:58 UTC

[GitHub] [groovy] paulk-asert opened a new pull request #1329: GROOVY-9637: Improve the performance of GString (closes #1329)

paulk-asert opened a new pull request #1329:
URL: https://github.com/apache/groovy/pull/1329


   Co-authored-by: Daniel Sun sunlan@apache.org
   Co-authored-by: Jochen Theodorou <bl...@gmx.org>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] danielsun1106 commented on pull request #1329: GROOVY-9637: Improve the performance of GString (closes #1329)

Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1329:
URL: https://github.com/apache/groovy/pull/1329#issuecomment-667417724


   Merged. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] danielsun1106 commented on pull request #1329: GROOVY-9637: Improve the performance of GString (closes #1329)

Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1329:
URL: https://github.com/apache/groovy/pull/1329#issuecomment-667551313


   @blackdrag 
   Yep ;-) About only 290ms costs in the simple benchmark on machine when the PR applied.
   
   ```groovy
   def gstr = makeGString()
   long b = System.currentTimeMillis()
   for (int i = 0; i < 10000000; i++) {
   	gstr.toString()
   }
   long e = System.currentTimeMillis()
   println "${e - b}ms"
   
   //@groovy.transform.CompileStatic
   def makeGString() {
       def now = java.time.LocalDateTime.now()
       "integer: ${1}, double: ${1.2d}, string: ${'x'}, class: ${Map.class}, boolean: ${true}, now: ${now}"
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] blackdrag commented on pull request #1329: GROOVY-9637: Improve the performance of GString (closes #1329)

Posted by GitBox <gi...@apache.org>.
blackdrag commented on pull request #1329:
URL: https://github.com/apache/groovy/pull/1329#issuecomment-667505876


   I think we got a good solution in the end


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] asfgit closed pull request #1329: GROOVY-9637: Improve the performance of GString (closes #1329)

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1329:
URL: https://github.com/apache/groovy/pull/1329


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org