You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/10/18 15:48:24 UTC
[GitHub] [myfaces] volosied opened a new pull request, #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
volosied opened a new pull request, #354:
URL: https://github.com/apache/myfaces/pull/354
https://issues.apache.org/jira/browse/MYFACES-4469
I don't expect users to wrap these factories more than once, but I used a while loop just in case (but I could switch to a if instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by "pnicolucci (via GitHub)" <gi...@apache.org>.
pnicolucci commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1520402041
For reference: https://github.com/apache/myfaces/commit/f842c82c9c688fdf804fa8f488723ccdf5551e26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1340349512
Thanks for the reviews. The user who reported this error says they encountered some problem with this fix. Not sure why, but I'm trying to get more information from them before I merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1486839436
@volosied please check my commit, i fixed it in a different way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko closed pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by GitBox <gi...@apache.org>.
tandraschko closed pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
URL: https://github.com/apache/myfaces/pull/354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1378744008
i will close this PR for now
please come back with a reproducer in the JIRA ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1478015363
IMO we should completely refactor this
there is no need to use reflection
we just need unwrap until we have e.g. a FacesContextImplBase and call #purgeFacesContext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1342248286
a reproducer would be great for such issues
we have a simple primefaces-test project which runs with all mojarra+myfaces versions on jetty
quite easy to replicate it something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko closed pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko closed pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
URL: https://github.com/apache/myfaces/pull/354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1318522154
i dont understand the case exactly but when it works and doesnt break something else -> +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1477863978
I see my error. I left out `facesContextPurgeMethod = getPurgeMethod(facesContext, "purgeFacesContext", NO_PARAMETER_TYPES);`
Builds passes now. If no objections, I will merge later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1476762678
Build failed due to :
```
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project myfaces-impl: Compilation failure
Error: /home/runner/work/myfaces/myfaces/impl/src/main/java/org/apache/myfaces/config/FacesConfigurator.java:[571,13] variable facesContextPurgeMethod might not have been initialized
Error: -> [Help 1]
```
But my local run only encounters:
```
-------------------------------------------------------------------------------
Test set: javax.faces.validator._MessageUtilsTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.379 sec <<< FAILURE! - in javax.faces.validator._MessageUtilsTest
testErrorMessage(javax.faces.validator._MessageUtilsTest) Time elapsed: 0.379 sec <<< ERROR!
java.lang.NullPointerException: null
at javax.faces.validator._MessageUtils.getBundle(_MessageUtils.java:189)
at javax.faces.validator._MessageUtils.getApplicationBundle(_MessageUtils.java:131)
at javax.faces.validator._MessageUtils.getMessage(_MessageUtils.java:65)
at javax.faces.validator._MessageUtils.getErrorMessage(_MessageUtils.java:42)
at javax.faces.validator._MessageUtilsTest.testErrorMessage(_MessageUtilsTest.java:69)
```
???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org