You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/05/17 18:27:55 UTC
[GitHub] [struts] JCgH4164838Gh792C124B5 opened a new pull request #417: Provide unit test for partial backport PR#416 for 2.5.x
JCgH4164838Gh792C124B5 opened a new pull request #417:
URL: https://github.com/apache/struts/pull/417
Provide unit test for partial backport PR#416 for 2.5.x (from L. Lenart's PR#414) :
- DispatcherTest provides code coverage tests of all getLocale() paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #417: Provide unit test for partial backport PR#416 for 2.5.x
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841098
Hello Apache Struts Team.
The PR #416 was already accepted and merged, but Coveralls pointed out that code-coverage dropped. Due to the potentially bad behaviour that could arise if Dispatcher Locale handling does not work as expected, a new set of unit tests for the Dispatcher getLocale() method has been created to confirm the expected behaviour.
If this PR looks OK to everyone, then it can be cherry-picked and modified as necessary to bring the tests into the 2.6.x stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart merged pull request #417: Provide unit test for partial backport PR#416 for 2.5.x
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #417:
URL: https://github.com/apache/struts/pull/417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] coveralls commented on pull request #417: Provide unit test for partial backport PR#416 for 2.5.x
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841861
[](https://coveralls.io/builds/30845133)
Coverage increased (+0.02%) to 47.096% when pulling **4457f03c70dba544962482fcef5d58a29ba1fe61 on JCgH4164838Gh792C124B5:LL_tiny-improvements_unittest** into **3d3512a399d3ddafca74f29ca3abef853db50506 on apache:struts-2-5-x**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 edited a comment on pull request #417: Provide unit test for partial backport PR#416 for 2.5.x
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 edited a comment on pull request #417:
URL: https://github.com/apache/struts/pull/417#issuecomment-629841098
Hello Apache Struts Team.
The PR #416 was already accepted and merged, but Coveralls pointed out that code-coverage dropped. Due to the potentially bad behaviour that could arise if `Dispatcher` `Locale` handling does not work as expected, a new set of unit tests for the `Dispatcher` `getLocale()` method has been created to confirm the expected behaviour.
If this PR looks OK to everyone, then it can be cherry-picked and modified as necessary to bring the tests into the 2.6.x stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org