You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jörn Franke <jo...@gmail.com> on 2014/03/11 22:16:07 UTC

Review Request 19070: MESOS-471: added all command line switches to documentation.md

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-471
    https://issues.apache.org/jira/browse/MESOS-471


Repository: mesos-git


Description
-------

added all command line switches to documentation


Diffs
-----

  docs/configuration.md 894528638917a1bd16dc4693a5cea802ddd020cd 

Diff: https://reviews.apache.org/r/19070/diff/


Testing
-------


Thanks,

Jörn Franke

Re: Review Request 19070: MESOS-471: added all command line switches to documentation.md

Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/#review37672
-----------------------------------------------------------

Ship it!


Ship It!

- Chengwei Yang


On March 19, 2014, 5:35 a.m., Jörn Franke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19070/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 5:35 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-471
>     https://issues.apache.org/jira/browse/MESOS-471
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> added all command line switches to documentation
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2dbe0f8 
> 
> Diff: https://reviews.apache.org/r/19070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jörn Franke
> 
>

Re: Review Request 19070: MESOS-471: added all command line switches to documentation.md

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/#review37648
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19070]

All tests passed.

- Mesos ReviewBot


On March 18, 2014, 9:35 p.m., Jörn Franke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19070/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 9:35 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-471
>     https://issues.apache.org/jira/browse/MESOS-471
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> added all command line switches to documentation
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 2dbe0f8 
> 
> Diff: https://reviews.apache.org/r/19070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jörn Franke
> 
>

Re: Review Request 19070: MESOS-471: added all command line switches to documentation.md

Posted by Jörn Franke <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/
-----------------------------------------------------------

(Updated March 18, 2014, 9:35 p.m.)


Review request for mesos.


Changes
-------

updated based on comments from reviewers


Bugs: MESOS-471
    https://issues.apache.org/jira/browse/MESOS-471


Repository: mesos-git


Description
-------

added all command line switches to documentation


Diffs (updated)
-----

  docs/configuration.md 2dbe0f8 

Diff: https://reviews.apache.org/r/19070/diff/


Testing
-------


Thanks,

Jörn Franke

Re: Review Request 19070: MESOS-471: added all command line switches to documentation.md

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/#review36916
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19070]

All tests passed.

- Mesos ReviewBot


On March 11, 2014, 9:16 p.m., Jörn Franke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19070/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 9:16 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-471
>     https://issues.apache.org/jira/browse/MESOS-471
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> added all command line switches to documentation
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 894528638917a1bd16dc4693a5cea802ddd020cd 
> 
> Diff: https://reviews.apache.org/r/19070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jörn Franke
> 
>

Re: Review Request 19070: MESOS-471: added all command line switches to documentation.md

Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19070/#review37329
-----------------------------------------------------------



docs/configuration.md
<https://reviews.apache.org/r/19070/#comment68840>

    trailing space



docs/configuration.md
<https://reviews.apache.org/r/19070/#comment68842>

    For consistency, this should be [no-]root_submissions, like below [no-]cgroups_enable_cfs.
    
    There are another several this kinds of inconsistency in this patch, for example, [no-]help, [no-]quiet and so on.



docs/configuration.md
<https://reviews.apache.org/r/19070/#comment68841>

    trailing space



docs/configuration.md
<https://reviews.apache.org/r/19070/#comment68843>

    trailing space


- Chengwei Yang


On March 12, 2014, 5:16 a.m., Jörn Franke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19070/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 5:16 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-471
>     https://issues.apache.org/jira/browse/MESOS-471
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> added all command line switches to documentation
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 894528638917a1bd16dc4693a5cea802ddd020cd 
> 
> Diff: https://reviews.apache.org/r/19070/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jörn Franke
> 
>