[GitHub] [pinot] xiangfu0 commented on a change in pull request #8158: [issue-8157] upgrade calcite due to cve

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #8158:
URL: https://github.com/apache/pinot/pull/8158#discussion_r805200267



##########
File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -710,14 +711,18 @@ private static Expression compileFunctionExpression(SqlBasicCall functionNode) {
           compilePathExpression(functionName, functionNode, path);
           return RequestUtils.getIdentifierExpression(path.toString());
         }
+        if ((functionNode.getFunctionQuantifier() != null) && ("DISTINCT".equals(
+            functionNode.getFunctionQuantifier().toString()))) {
+          functionName = "DISTINCTCOUNT";

Review comment:
       I think the issue is that the old behavior has `functionKind == COUNT`, so it goes to line 698.
   The new parser makes `functionKind = OTHER_FUNCTION`.
   
   The difference here is pinot internal has the implementation of DISTINTCOUNT as a single function, SUM(DISTINCT) cannot be treated as a single function and hence not supported.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org