You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2018/08/31 14:36:31 UTC
[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11373
Change subject: KUDU-2529: Add a "-tables=<tables>" flag to the "kudu table list".
......................................................................
KUDU-2529: Add a "-tables=<tables>" flag to the "kudu table list".
"-tables=<tables>" flag can help to filter the tables that you want
while running "kudu table list <master> -list_tables".
Change-Id: I719902ae8b731e2bc77ab53c087db7fd289a980f
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 142 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11373/1
--
To view, visit http://gerrit.cloudera.org:8080/11373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I719902ae8b731e2bc77ab53c087db7fd289a980f
Gerrit-Change-Number: 11373
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11373 )
Change subject: KUDU-2529: Add a "-tables=<tables>" flag to the "kudu table list".
......................................................................
Abandoned
Submitted in https://gerrit.cloudera.org/c/11360.
--
To view, visit http://gerrit.cloudera.org:8080/11373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I719902ae8b731e2bc77ab53c087db7fd289a980f
Gerrit-Change-Number: 11373
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2529: Add a "-tables=" flag to the "kudu table list".
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11373 )
Change subject: KUDU-2529: Add a "-tables=<tables>" flag to the "kudu table list".
......................................................................
Patch Set 1:
Looks like when you published your new commit, you dropped the Change-Id line and your post-commit hook generated a new one, which resulted in a brand new Gerrit change.
Could you amend this commit to replace the Change-Id with the one found in https://gerrit.cloudera.org/c/11360? That way we can continue reviewing the patch in the same place, and the interdiff between patch revisions will work.
Also, you've got some test failures to fix, as well as some clang-tidy suggestions.
--
To view, visit http://gerrit.cloudera.org:8080/11373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I719902ae8b731e2bc77ab53c087db7fd289a980f
Gerrit-Change-Number: 11373
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Fri, 31 Aug 2018 17:38:04 +0000
Gerrit-HasComments: No