You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/05/26 13:37:46 UTC

[GitHub] [camel-k] gansheer opened a new pull request, #4417: feat(core): Support S2I for builder image generation

gansheer opened a new pull request, #4417:
URL: https://github.com/apache/camel-k/pull/4417

   Ref #4297
   
   ## Motivation
   
   Add S2I support for builder image generation for better support on Openshift.
   
   ## Description
   
   * Add initialize builder image on catalog:
   * creates (or replace) a BuildConfig resource
   * creates (or replace) an ImageStream resource
   * create a new builder image from dockerfile and source binary
   * Light refactoring of S2I code
   
   The `HOME` env variable has been added on builder image execution to some errors on file permissions without.
   
   
   **Release Note**
   ```release-note
   Add S2I support for builder image generation
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] gansheer commented on pull request #4417: feat(core): Support S2I for builder image generation

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4417:
URL: https://github.com/apache/camel-k/pull/4417#issuecomment-1564412328

   @lburgazzoli @astefanutti and anyone who have some knowledge on Openshift please don't hesitate to review, I would really some openshift feedback :smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] gansheer commented on pull request #4417: feat(core): Support S2I for builder image generation

Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on PR #4417:
URL: https://github.com/apache/camel-k/pull/4417#issuecomment-1567021590

   > @gansheer please, let me know when it's ready to merge. If you're addressing the comments provided in the PR or we create follow up issues.
   
   On my side it is ready to merge
   
   I took care of some part of the refactoring, but for the more complex part of refactoring I would prefer we open a follow up issue when the olm tests are more reliable after the 1.12.1 release as it could be impacted by #4418.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #4417: feat(core): Support S2I for builder image generation

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4417:
URL: https://github.com/apache/camel-k/pull/4417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #4417: feat(core): Support S2I for builder image generation

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4417:
URL: https://github.com/apache/camel-k/pull/4417#issuecomment-1567083509

   Merged. Please, take care to log any relevant follow up issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #4417: feat(core): Support S2I for builder image generation

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4417:
URL: https://github.com/apache/camel-k/pull/4417#issuecomment-1566995266

   @gansheer please, let me know when it's ready to merge. If you're addressing the comments provided in the PR or we create follow up issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org