You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/10 19:50:47 UTC
Re: Review Request 47658: ATLAS-499: Update reverse references
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47658/#review165156
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java (line 748)
<https://reviews.apache.org/r/47658/#comment236966>
Isn't there a need for "removeReverseReference()" - to update the reverseAttribute when a referred entity is deleted? For example: when a hive_column entity is deleted, hive_table.columns needs to be updated.
Perhaps this is already handled in the current implementation. If so, please ignore this comment.
- Madhan Neethiraj
On June 17, 2016, 2:44 a.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47658/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 2:44 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-499
> https://issues.apache.org/jira/browse/ATLAS-499
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-499: Automatically update inverse references to prevent repository corruption from unbalanced references.
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14
> addons/hive-bridge/src/test/resources/je.properties PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 91f9bd008a6939dfe78656f5c1845637a30ee9eb
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 4f6d0118072380342f5ea302d0aaf7902784849a
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 4c1f5591f4adead41c3336e64b0bc956836f7edb
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 449e066a167ba4546b118a77c8e3de5fd99f077b
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47658/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>
Re: Review Request 47658: ATLAS-499: Update reverse references
Posted by David Kantor <dk...@us.ibm.com>.
> On Feb. 10, 2017, 7:50 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java, line 749
> > <https://reviews.apache.org/r/47658/diff/8/?file=1421934#file1421934line749>
> >
> > Isn't there a need for "removeReverseReference()" - to update the reverseAttribute when a referred entity is deleted? For example: when a hive_column entity is deleted, hive_table.columns needs to be updated.
> >
> > Perhaps this is already handled in the current implementation. If so, please ignore this comment.
This is already handled in DeleteHandler.deleteEdge(). Also this review request had been discarded a few days ago, so that I could separate the V1 and V2 changes. If you have any further review comments on the V1 changes, please post them to https://reviews.apache.org/r/56287/
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47658/#review165156
-----------------------------------------------------------
On June 17, 2016, 2:44 a.m., David Kantor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47658/
> -----------------------------------------------------------
>
> (Updated June 17, 2016, 2:44 a.m.)
>
>
> Review request for atlas and Shwetha GS.
>
>
> Bugs: ATLAS-499
> https://issues.apache.org/jira/browse/ATLAS-499
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-499: Automatically update inverse references to prevent repository corruption from unbalanced references.
>
>
> Diffs
> -----
>
> addons/hive-bridge/pom.xml 47e72e814a421f03b00a9b7c6a13163e1b67ca14
> addons/hive-bridge/src/test/resources/je.properties PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 91f9bd008a6939dfe78656f5c1845637a30ee9eb
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 4f6d0118072380342f5ea302d0aaf7902784849a
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java 4c1f5591f4adead41c3336e64b0bc956836f7edb
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 449e066a167ba4546b118a77c8e3de5fd99f077b
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47658/diff/
>
>
> Testing
> -------
>
> Ran all unit and integration tests with no regressions.
>
>
> Thanks,
>
> David Kantor
>
>