You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/06/24 21:24:55 UTC
[GitHub] [hbase] jatsakthi commented on a change in pull request #333:
[HBASE-22606] : BucketCache additional tests
jatsakthi commented on a change in pull request #333: [HBASE-22606] : BucketCache additional tests
URL: https://github.com/apache/hbase/pull/333#discussion_r296921841
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
##########
@@ -255,51 +256,108 @@ public void run() {
@Test
public void testRetrieveFromFile() throws Exception {
- HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();
- Path testDir = TEST_UTIL.getDataTestDir();
- TEST_UTIL.getTestFileSystem().mkdirs(testDir);
-
+ Path testDir = HBASE_TESTING_UTILITY.getDataTestDir();
Review comment:
These two lines for creation of test directory can be consolidated by usage of a private function to reduce code duplication, as there are multiple instances of these?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services