[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6836: [HUDI-4952] Fixing reading from metadata table when there are no inflight commits

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #6836:
URL: https://github.com/apache/hudi/pull/6836#discussion_r991629981


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieFileIndex.scala:
##########
@@ -403,7 +404,7 @@ class TestHoodieFileIndex extends HoodieClientTestBase {
       val allFilesPartitions = fileIndex.listFiles(Seq(), Seq())
       assertEquals(10, allFilesPartitions.head.files.length)
 
-      if (testCase.enableDataSkipping && testCase.enableMetadata) {
+      if (testCase.enableDataSkipping && testCase.enableMetadata && testCase.enableColumnStats) {

Review Comment:
   Can you please elaborate why we need to change this one?



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -267,10 +266,15 @@ case class HoodieFileIndex(spark: SparkSession,
         s"(isMetadataTableEnabled = $isMetadataTableEnabled, isColumnStatsIndexEnabled = $isColumnStatsIndexEnabled")
     }
   }
+
 }
 
 object HoodieFileIndex extends Logging {
 
+  def getBooleanConfigValue(sqlConf: SQLConf, options: Map[String, String], configKey: String, defaultValue: String) : Boolean = {

Review Comment:
   Let's swap in SQLConf and opts order so that it matches the order of retrieving the values from them correspondingly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org