[GitHub] [kyuubi] turboFei commented on pull request #4344: Expose exec pool work queue size metrics

["turboFei (via GitHub)" <gi...@apache.org>]

turboFei commented on PR #4344:
URL: https://github.com/apache/kyuubi/pull/4344#issuecomment-1433028917

   I think work queue should be fine, it is a normal concept in `ThreadPoolExecutor`.
   
   ```
       /**
        * The queue used for holding tasks and handing off to worker
        * threads.  We do not require that workQueue.poll() returning
        * null necessarily means that workQueue.isEmpty(), so rely
        * solely on isEmpty to see if the queue is empty (which we must
        * do for example when deciding whether to transition from
        * SHUTDOWN to TIDYING).  This accommodates special-purpose
        * queues such as DelayQueues for which poll() is allowed to
        * return null even if it may later return non-null when delays
        * expire.
        */
       private final BlockingQueue<Runnable> workQueue;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org