[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5170: [INLONG-5169][Sort] Fix race condition issue of HBaseSinkFunction metric collection

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #5170:
URL: https://github.com/apache/inlong/pull/5170#discussion_r928060651


##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -80,13 +79,10 @@
     private transient ScheduledExecutorService executor;
     private transient ScheduledFuture scheduledFuture;
     private transient AtomicLong numPendingRequests;
-    private transient RuntimeContext runtimeContext;
 
     private transient volatile boolean closed = false;
 
     private MetricData metricData;
-    private Long dataSize = 0L;
-    private Long rowSize = 0L;

Review Comment:
   The original logic should be fine, just turn it into an atomic variable.



##########
inlong-sort/sort-connectors/hbase/src/main/java/org/apache/inlong/sort/hbase/sink/HBaseSinkFunction.java:
##########
@@ -80,13 +79,10 @@
     private transient ScheduledExecutorService executor;
     private transient ScheduledFuture scheduledFuture;
     private transient AtomicLong numPendingRequests;
-    private transient RuntimeContext runtimeContext;
 
     private transient volatile boolean closed = false;
 
     private MetricData metricData;
-    private Long dataSize = 0L;

Review Comment:
   The original logic should be fine, just turn it into an atomic variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org