You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Tran (JIRA)" <ji...@codehaus.org> on 2008/12/07 08:43:19 UTC

[jira] Created: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
--------------------------------------------------------------------------------------------------------

                 Key: WAGON-248
                 URL: http://jira.codehaus.org/browse/WAGON-248
             Project: Maven Wagon
          Issue Type: Bug
          Components: wagon-file
    Affects Versions: 1.0-beta-4
         Environment: windows, linux
            Reporter: Dan Tran


When the requested resource has a "/" at the end, it is an indication of directory check.

The fix is needed to get wagon:list working with file protocol



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran updated WAGON-248:
---------------------------

    Fix Version/s: 1.0-beta-5

> wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WAGON-248
>                 URL: http://jira.codehaus.org/browse/WAGON-248
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>    Affects Versions: 1.0-beta-4
>         Environment: windows, linux
>            Reporter: Dan Tran
>             Fix For: 1.0-beta-5
>
>
> When the requested resource has a "/" at the end, it is an indication of directory check.
> The fix is needed to get wagon:list working with file protocol

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran closed WAGON-248.
--------------------------

      Assignee: Dan Tran
    Resolution: Fixed

fixed at

Revision: 724228
Author: dantran
Date: 5:22:01 PM, Sunday, December 07, 2008
Message:
WAGON-248: wagon-file's FileWagon.resourceExists should check for directory when requested resouce indicate it is a directory
----
Modified : /maven/wagon/trunk/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java
Modified : /maven/wagon/trunk/wagon-providers/wagon-file/src/test/java/org/apache/maven/wagon/providers/file/FileWagonTest.java



> wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WAGON-248
>                 URL: http://jira.codehaus.org/browse/WAGON-248
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>    Affects Versions: 1.0-beta-4
>         Environment: windows, linux
>            Reporter: Dan Tran
>            Assignee: Dan Tran
>             Fix For: 1.0-beta-5
>
>         Attachments: WAGON-248.diff
>
>
> When the requested resource has a "/" at the end, it is an indication of directory check.
> The fix is needed to get wagon:list working with file protocol

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/WAGON-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157189#action_157189 ] 

Brett Porter commented on WAGON-248:
------------------------------------

looks good to me, you should go ahead and apply it.

Does that test apply to other providers as well?

> wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WAGON-248
>                 URL: http://jira.codehaus.org/browse/WAGON-248
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>    Affects Versions: 1.0-beta-4
>         Environment: windows, linux
>            Reporter: Dan Tran
>             Fix For: 1.0-beta-5
>
>         Attachments: WAGON-248.diff
>
>
> When the requested resource has a "/" at the end, it is an indication of directory check.
> The fix is needed to get wagon:list working with file protocol

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/WAGON-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157204#action_157204 ] 

Dan Tran commented on WAGON-248:
--------------------------------

The attached test only applies to wagon-file at this moment.  

In the long term, we should come up with a common test for all providers.



> wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WAGON-248
>                 URL: http://jira.codehaus.org/browse/WAGON-248
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>    Affects Versions: 1.0-beta-4
>         Environment: windows, linux
>            Reporter: Dan Tran
>             Fix For: 1.0-beta-5
>
>         Attachments: WAGON-248.diff
>
>
> When the requested resource has a "/" at the end, it is an indication of directory check.
> The fix is needed to get wagon:list working with file protocol

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran updated WAGON-248:
---------------------------

    Testcase included: yes
      Patch Submitted: [Yes]

> wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WAGON-248
>                 URL: http://jira.codehaus.org/browse/WAGON-248
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>    Affects Versions: 1.0-beta-4
>         Environment: windows, linux
>            Reporter: Dan Tran
>             Fix For: 1.0-beta-5
>
>         Attachments: WAGON-248.diff
>
>
> When the requested resource has a "/" at the end, it is an indication of directory check.
> The fix is needed to get wagon:list working with file protocol

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (WAGON-248) wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/WAGON-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran updated WAGON-248:
---------------------------

    Attachment: WAGON-248.diff

attached is the patch with test

> wagon-file's FileWagon.resourceExists should check for directory when resouce indicate it is a directory
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WAGON-248
>                 URL: http://jira.codehaus.org/browse/WAGON-248
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-file
>    Affects Versions: 1.0-beta-4
>         Environment: windows, linux
>            Reporter: Dan Tran
>             Fix For: 1.0-beta-5
>
>         Attachments: WAGON-248.diff
>
>
> When the requested resource has a "/" at the end, it is an indication of directory check.
> The fix is needed to get wagon:list working with file protocol

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira