[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1680: TINKERPOP-2708: unhandledRejection upon connection failure

[GitBox <gi...@apache.org>]

lyndonbauto commented on code in PR #1680:
URL: https://github.com/apache/tinkerpop/pull/1680#discussion_r891542401


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js:
##########
@@ -103,13 +103,15 @@ class Connection extends EventEmitter {
     this._pingIntervalDelay = this.options.pingInterval || pingIntervalDelay;
     this._pongTimeoutDelay = this.options.pongTimeout || pongTimeoutDelay;
 
-    if (this.options.connectOnStartup !== false) {
-      this.open();
+    if (this.options.connectOnStartup) {

Review Comment:
   The above comment that was updated used to say the default was true, but that is not entirely correct is it? Technically it was just `!== false`?
   
   Just want to ensure this console warning will not be printing out when a user does not set this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org