You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/16 06:02:53 UTC

[GitHub] [rocketmq] cserwen opened a new issue #3992: Some code optimizations about BrokerContainerStartup

cserwen opened a new issue #3992:
URL: https://github.com/apache/rocketmq/issues/3992


   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - Some optimizations about `BrokerContainerStartup.class`
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
   - replace `"c"` with static field `BROKER_CONTAINER_CONFIG_OPTION`, others too.
   - rename `brokerConfig` to `containerConfig`
   - remove boolean param of  createBrokerContainer which is useless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin commented on issue #3992: Some code optimizations about BrokerContainerStartup

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3992:
URL: https://github.com/apache/rocketmq/issues/3992#issuecomment-1070883283


   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin closed issue #3992: Some code optimizations about BrokerContainerStartup

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3992:
URL: https://github.com/apache/rocketmq/issues/3992


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin commented on issue #3992: Some code optimizations about BrokerContainerStartup

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3992:
URL: https://github.com/apache/rocketmq/issues/3992#issuecomment-1070883283


   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin closed issue #3992: Some code optimizations about BrokerContainerStartup

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3992:
URL: https://github.com/apache/rocketmq/issues/3992


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org