[jira] [Resolved] (HBASE-9059) Address HBASE-8764 'Some MasterMonitorCallable should retry' review

["Michael Stack (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stack resolved HBASE-9059.
----------------------------------
    Resolution: Won't Fix

Stale. Context is different now.

> Address HBASE-8764 'Some MasterMonitorCallable should retry' review
> -------------------------------------------------------------------
>
>                 Key: HBASE-9059
>                 URL: https://issues.apache.org/jira/browse/HBASE-9059
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Major
>
> Jesse came in w/ some review post-commit.  Let me address in this followup.  Let me paste form our offlist correspondence:
> {quote}
> +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionOfflineException.java
> @@ -24,7 +24,7 @@ import org.apache.hadoop.hbase.exceptions.RegionException;
>  
>  /** Thrown when a table can not be located */
>  @InterfaceAudience.Public
> -@InterfaceStability.Stable
> +@InterfaceStability.Evolving
> Really? Same patch? Come on man - you are doing similar cleanup all over the place (shakes head)... :)
> +@InterfaceStability.Stable
> +public class RpcRetryingCaller<T> {
> Calling this stable as the first time its going in seems a bit presumptuous...
> +    this.startTime = EnvironmentEdgeManager.currentTimeMillis();
> +    int remaining = (int)(callTimeout - (this.startTime - this.globalStartTime));
> +    if (remaining < MIN_RPC_TIMEOUT) {
> +      // If there is no time left, we're trying anyway. It's too late.
> +      // 0 means no timeout, and it's not the intent here. So we secure both cases by
> +      // resetting to the minimum.
> +      remaining = MIN_RPC_TIMEOUT;
> +    }
> +    RpcClient.setRpcTimeout(remaining);
> Looks like some new logic... seems reasonable to me, so I'll let it slide this time :)
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)