[GitHub] [echarts] pissang commented on a diff in pull request #16939: fix: tooltip content changes with axis extent when 'triggerOn' set to 'click'

[GitBox <gi...@apache.org>]

pissang commented on code in PR #16939:
URL: https://github.com/apache/echarts/pull/16939#discussion_r859311077


##########
src/component/tooltip/TooltipView.ts:
##########
@@ -257,6 +257,7 @@ class TooltipView extends ComponentView {
             // self.manuallyShowTip({x, y}) might cause tooltip hide,
             // which is not expected.
             && tooltipModel.get('triggerOn') !== 'none'
+            && tooltipModel.get('triggerOn') !== 'click'

Review Comment:
   It will be better to cache the `tooltipModel.get('triggerOn')` to a temporal variable `triggerOn` if there are multiple accesses.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org