You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/08/24 14:53:04 UTC
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi/pull/2965
NIFI-5542 Added support for node groups to FileAccessPolicyProvider
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi NIFI-5542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2965.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2965
----
commit d957f655a17dff8cd464f0a1e2b44d6031410fec
Author: Andrew I. Christianson <an...@...>
Date: 2018-08-23T15:50:54Z
NIFI-5542 Added support for node groups to FileAccessPolicyProvider
----
---
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson closed the pull request at:
https://github.com/apache/nifi/pull/2965
---
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
Posted by pepov <gi...@git.apache.org>.
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2965#discussion_r212879535
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAccessPolicyProvider.java ---
@@ -604,12 +610,26 @@ private void populateInitialAdmin(final Authorizations authorizations) {
* @param authorizations the overall authorizations
*/
private void populateNodes(Authorizations authorizations) {
+ // authorize static nodes
+ authorizeNodeIdentities(authorizations, nodeIdentities);
+
+ // authorize dynamic nodes (node group)
+ if (nodeGroupName != null) {
+ Group nodeGroup = userGroupProvider.getGroup(nodeGroupName);
+ if (nodeGroup == null) {
+ throw new AuthorizerCreationException("Unable to locate node group " + nodeGroupName + " to seed policies.");
+ }
+ Set<String> nodeGroupUserIdentities = nodeGroup.getUsers();
+ authorizeNodeIdentities(authorizations, nodeGroupUserIdentities);
--- End diff --
I'm not intimate with how this works, but wouldn't this just authorize the users in the group initially and not the group itself? I mean will this authorization include nodes added later to the group? Is there a way to do the same authorization on the group object directly?
---
[GitHub] nifi pull request #2965: NIFI-5542 Added support for node groups to FileAcce...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2965#discussion_r212977830
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAccessPolicyProvider.java ---
@@ -604,12 +610,26 @@ private void populateInitialAdmin(final Authorizations authorizations) {
* @param authorizations the overall authorizations
*/
private void populateNodes(Authorizations authorizations) {
+ // authorize static nodes
+ authorizeNodeIdentities(authorizations, nodeIdentities);
+
+ // authorize dynamic nodes (node group)
+ if (nodeGroupName != null) {
+ Group nodeGroup = userGroupProvider.getGroup(nodeGroupName);
+ if (nodeGroup == null) {
+ throw new AuthorizerCreationException("Unable to locate node group " + nodeGroupName + " to seed policies.");
+ }
+ Set<String> nodeGroupUserIdentities = nodeGroup.getUsers();
+ authorizeNodeIdentities(authorizations, nodeGroupUserIdentities);
--- End diff --
Hmm, good point. It depends on how/when the FileAccessPolicyProvider is called. Looking into it...
---