You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/12/06 08:54:02 UTC
Review Request 54410: Made the style of `.navbar-text` consistent with
others.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Vinod Kone.
Repository: mesos
Description
-------
Made the style of `.navbar-text` consistent with other texts in the
navbar.
Diffs
-----
src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
Diff: https://reviews.apache.org/r/54410/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 7:58 a.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Bugs: MESOS-6725
https://issues.apache.org/jira/browse/MESOS-6725
Repository: mesos
Description
-------
Made the style of the cluster name consistent with other texts in the
navbar.
Diffs
-----
src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
Diff: https://reviews.apache.org/r/54410/diff/
Testing (updated)
-------
# Before:
# After:
Thanks,
haosdent huang
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 7:51 a.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Changes
-------
Address @bmahler's comment.
Bugs: MESOS-6725
https://issues.apache.org/jira/browse/MESOS-6725
Repository: mesos
Description
-------
Made the style of the cluster name consistent with other texts in the
navbar.
Diffs (updated)
-----
src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
Diff: https://reviews.apache.org/r/54410/diff/
Testing
-------
# Before:
# After:
Thanks,
haosdent huang
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
Posted by haosdent huang <ha...@gmail.com>.
> On Dec. 9, 2016, 7:51 p.m., Benjamin Mahler wrote:
> > If it looks the same as the other navbar tabs, it seems clickable? At least when it is greyed out I wouldn't think I can click it.
Got it, use `btn disabled` to make it grey now.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/#review158716
-----------------------------------------------------------
On Dec. 13, 2016, 7:58 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54410/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 7:58 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-6725
> https://issues.apache.org/jira/browse/MESOS-6725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the style of the cluster name consistent with other texts in the
> navbar.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/54410/diff/
>
>
> Testing
> -------
>
> # Before:
>
> 
>
> # After:
>
> 
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
Posted by Jacob Janco <jj...@gmail.com>.
> On Dec. 9, 2016, 7:51 p.m., Benjamin Mahler wrote:
> > If it looks the same as the other navbar tabs, it seems clickable? At least when it is greyed out I wouldn't think I can click it.
>
> haosdent huang wrote:
> Got it, use `btn disabled` to make it grey now.
Hey, responding to your review req ->
I checked the current styling and it looks consistent for me with no change, alignment/text size and font is the same.
- Jacob
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/#review158716
-----------------------------------------------------------
On Dec. 13, 2016, 7:58 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54410/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 7:58 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-6725
> https://issues.apache.org/jira/browse/MESOS-6725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the style of the cluster name consistent with other texts in the
> navbar.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/54410/diff/
>
>
> Testing
> -------
>
> # Before:
>
> 
>
> # After:
>
> 
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/#review158716
-----------------------------------------------------------
If it looks the same as the other navbar tabs, it seems clickable? At least when it is greyed out I wouldn't think I can click it.
- Benjamin Mahler
On Dec. 7, 2016, 8:27 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54410/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 8:27 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-6725
> https://issues.apache.org/jira/browse/MESOS-6725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the style of the cluster name consistent with other texts in the
> navbar.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
>
> Diff: https://reviews.apache.org/r/54410/diff/
>
>
> Testing
> -------
>
> # Before:
>
> 
>
> # After:
>
> 
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54410: Made the style of the cluster name
consistent with others.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
(Updated Dec. 7, 2016, 8:27 a.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Changes
-------
Address @bmahler's comment.
Summary (updated)
-----------------
Made the style of the cluster name consistent with others.
Bugs: MESOS-6725
https://issues.apache.org/jira/browse/MESOS-6725
Repository: mesos
Description (updated)
-------
Made the style of the cluster name consistent with other texts in the
navbar.
Diffs (updated)
-----
src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42
Diff: https://reviews.apache.org/r/54410/diff/
Testing
-------
# Before:
# After:
Thanks,
haosdent huang
Re: Review Request 54410: Made the style of `.navbar-text` consistent
with others.
Posted by haosdent huang <ha...@gmail.com>.
> On Dec. 6, 2016, 11:14 p.m., Benjamin Mahler wrote:
> > Is this just changing the color? What did the added margins do?
It is because
```
.navbar-text {
margin-top: 15px;
margin-bottom: 15px;
}
```
so I try to override it before. Another more simple way is change `<p>` to `<a>` directly. Have updated to this way.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/#review158247
-----------------------------------------------------------
On Dec. 6, 2016, 9:16 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54410/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 9:16 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-6725
> https://issues.apache.org/jira/browse/MESOS-6725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the style of `.navbar-text` consistent with other texts in the
> navbar.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
>
> Diff: https://reviews.apache.org/r/54410/diff/
>
>
> Testing
> -------
>
> # Before:
>
> 
>
> # After:
>
> 
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54410: Made the style of `.navbar-text` consistent
with others.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/#review158247
-----------------------------------------------------------
Is this just changing the color? What did the added margins do?
- Benjamin Mahler
On Dec. 6, 2016, 9:16 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54410/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 9:16 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Bugs: MESOS-6725
> https://issues.apache.org/jira/browse/MESOS-6725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the style of `.navbar-text` consistent with other texts in the
> navbar.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
>
> Diff: https://reviews.apache.org/r/54410/diff/
>
>
> Testing
> -------
>
> # Before:
>
> 
>
> # After:
>
> 
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 54410: Made the style of `.navbar-text` consistent
with others.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 9:16 a.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Bugs: MESOS-6725
https://issues.apache.org/jira/browse/MESOS-6725
Repository: mesos
Description
-------
Made the style of `.navbar-text` consistent with other texts in the
navbar.
Diffs
-----
src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
Diff: https://reviews.apache.org/r/54410/diff/
Testing (updated)
-------
# Before:
# After:
Thanks,
haosdent huang
Re: Review Request 54410: Made the style of `.navbar-text` consistent
with others.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 9:16 a.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Bugs: MESOS-6725
https://issues.apache.org/jira/browse/MESOS-6725
Repository: mesos
Description
-------
Made the style of `.navbar-text` consistent with other texts in the
navbar.
Diffs
-----
src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
Diff: https://reviews.apache.org/r/54410/diff/
Testing
-------
# Before:
# After:
Thanks,
haosdent huang
Re: Review Request 54410: Made the style of `.navbar-text` consistent
with others.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54410/
-----------------------------------------------------------
(Updated Dec. 6, 2016, 9:16 a.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Repository: mesos
Description
-------
Made the style of `.navbar-text` consistent with other texts in the
navbar.
Diffs
-----
src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
Diff: https://reviews.apache.org/r/54410/diff/
Testing (updated)
-------
# Before:
# After:
Thanks,
haosdent huang