You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/09/25 12:19:08 UTC

[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1685: [Feature] Update the username index for t_user table

1996fanrui commented on PR #1685:
URL: https://github.com/apache/incubator-streampark/pull/1685#issuecomment-1257182140

   > Can you add a pgsql-upgrad.sql to the upgrade directory to record DDL and DML changes, `pgsql-schema.sql` also needs to update the `username index`
   
   Hi @xinzhuxiansheng , thanks for your review. As I know, #1449 added the `pgsql-schema.sql` at Aug 2022.  `streampark-1.2.3` doesn't support pgsql, `streampark-1.2.4` will be the first version that supports pgsql. So I think we don't need to prepare the `pgsql-upgrade.sql` at this version. Please correct me if I'm wrong.
   
   > upgrade directory, can we adjust it like dolphinscheduler upgrade sql? E.g : upgrade/(1.2.4-SNAPSHOT)_schema/(mysql/pgsql)/streampark_(ddl/dml).sql
   
   Great idea, absolutely agree. I can do it. Should we update the directory in this PR or create a new PR to do it? I prefer create a new issue and PR.
   
   Actually, it is not reasonable for some feature or bugfix or upgrade to be mixed into one commit. If a commit has a bug and needs to be rolled back, multiple features will be rolled back. In the long term, we also need the `Code Style and Quality Guide` like Flink : 
   
   https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#separate-refactoring-cleanup-and-independent-changes
   
   <img width="1105" alt="image" src="https://user-images.githubusercontent.com/38427477/192143006-61cecacd-bfab-4e52-bfc5-169a55e991ce.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org