[GitHub] [sling-org-apache-sling-models-jacksonexporter] stefanseifert commented on a change in pull request #4: SLING-10959 Sling Models Exporter: Migrate from Felix SCR annotations to OSGi R7 annotations, Update to Parent 46

[GitBox <gi...@apache.org>]

stefanseifert commented on a change in pull request #4:
URL: https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/4#discussion_r760906050



##########
File path: src/main/java/org/apache/sling/models/jacksonexporter/impl/JacksonExporter.java
##########
@@ -58,9 +56,7 @@
 
     private static final int MAPPER_FEATURE_PREFIX_LENGTH = MAPPER_FEATURE_PREFIX.length();
 
-    @Reference(name = "moduleProvider", referenceInterface = ModuleProvider.class,
-            cardinality = ReferenceCardinality.OPTIONAL_MULTIPLE, policy = ReferencePolicy.DYNAMIC)
-    private final RankedServices<ModuleProvider> moduleProviders = new RankedServices<ModuleProvider>(Order.ASCENDING);
+    private final RankedServices<ModuleProvider> moduleProviders = new RankedServices<>(Order.ASCENDING);

Review comment:
       the correct ordering of services injected here is not validated by any test case.
   
   i've created a separate ticket for this, let us not mix this in this PR: https://issues.apache.org/jira/browse/SLING-10964




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org