You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 18:13:22 UTC

Re: Review Request 68814: Added a test for `Option` / `Option`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68814/#review213033
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68813, 68814]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 23, 2018, 1:09 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68814/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2018, 1:09 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for `Option<T&>` / `Option<const T&>`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/option_tests.cpp 815d40e0bf342998634dc69a1719c3f717c7202c 
> 
> 
> Diff: https://reviews.apache.org/r/68814/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>