You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2026/03/03 17:38:44 UTC
[PR] [SPARK-55811] [SQL] Catch `NonFatal` instead of `UnresolvedException` when calling `nodeWithOutputColumnsString` [spark]
mihailoale-db opened a new pull request, #54600:
URL: https://github.com/apache/spark/pull/54600
### What changes were proposed in this pull request?
```
SELECT 1L UNION SELECT 1
```
fails with `CANNOT_MERGE_INCOMPATIBLE_DATA_TYPE` when `spark.sql.planChangeLog.level` is set to `info` because we call `Union.output` too early (before type coercion is performed). In this PR I propose to fix it by catching `NonFatal` instead of `UnresolvedException` when calling `nodeWithOutputColumnsString`.
### Why are the changes needed?
To fix an issue.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added + existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55811] [SQL] Catch `NonFatal` instead of `UnresolvedException` when calling `nodeWithOutputColumnsString` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #54600: [SPARK-55811] [SQL] Catch `NonFatal` instead of `UnresolvedException` when calling `nodeWithOutputColumnsString`
URL: https://github.com/apache/spark/pull/54600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55811] [SQL] Catch `NonFatal` instead of `UnresolvedException` when calling `nodeWithOutputColumnsString` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #54600:
URL: https://github.com/apache/spark/pull/54600#issuecomment-3999169973
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55811] [SQL] Catch `NonFatal` instead of `UnresolvedException` when calling `nodeWithOutputColumnsString` [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #54600:
URL: https://github.com/apache/spark/pull/54600#issuecomment-3996808168
@cloud-fan PTAL when you find time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org