You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Roger Hoover <ro...@gmail.com> on 2016/06/23 21:57:30 UTC

[DISCUSS] KAFKA-3761: Controller has RunningAsBroker instead of RunningAsController state

Hi all,

Does anyone have an issue with removing the broker state called
"RunningAsController"?

The reasons to remove it are:
1. It's currently broken.  The purpose of the JIRA
<https://issues.apache.org/jira/browse/KAFKA-3761> was to report that the
RunningAsController state gets overwritten back to "RunningAsBroker".
2. It's not a useful state.
  a. If clients want to use this metric to know whether a broker is ready
to receive requests or not, they do not care whether or not the broker is
the controller
  b. there is already a separate boolean property, KafkaController.isActive
which contains this information.

Thanks,

Roger

Re: [DISCUSS] KAFKA-3761: Controller has RunningAsBroker instead of RunningAsController state

Posted by Grant Henke <gh...@cloudera.com>.

+1 The Metadata response now has the controller broker in it too
leveraging KafkaController.isActive.
Clients can use that to identify the controller.

On Thu, Jun 23, 2016 at 7:17 PM, Gwen Shapira <gw...@confluent.io> wrote:

> +1 from me too
>
> On Thu, Jun 23, 2016 at 3:06 PM, Ismael Juma <is...@juma.me.uk> wrote:
> > +1 from me.
> >
> > Ismael
> >
> > On Thu, Jun 23, 2016 at 11:57 PM, Roger Hoover <ro...@gmail.com>
> > wrote:
> >
> >> Hi all,
> >>
> >> Does anyone have an issue with removing the broker state called
> >> "RunningAsController"?
> >>
> >> The reasons to remove it are:
> >> 1. It's currently broken.  The purpose of the JIRA
> >> <https://issues.apache.org/jira/browse/KAFKA-3761> was to report that
> the
> >> RunningAsController state gets overwritten back to "RunningAsBroker".
> >> 2. It's not a useful state.
> >>   a. If clients want to use this metric to know whether a broker is
> ready
> >> to receive requests or not, they do not care whether or not the broker
> is
> >> the controller
> >>   b. there is already a separate boolean property,
> KafkaController.isActive
> >> which contains this information.
> >>
> >> Thanks,
> >>
> >> Roger
> >>
>



-- 
Grant Henke
Software Engineer | Cloudera
grant@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke

Re: [DISCUSS] KAFKA-3761: Controller has RunningAsBroker instead of RunningAsController state

Posted by Gwen Shapira <gw...@confluent.io>.

+1 from me too

On Thu, Jun 23, 2016 at 3:06 PM, Ismael Juma <is...@juma.me.uk> wrote:
> +1 from me.
>
> Ismael
>
> On Thu, Jun 23, 2016 at 11:57 PM, Roger Hoover <ro...@gmail.com>
> wrote:
>
>> Hi all,
>>
>> Does anyone have an issue with removing the broker state called
>> "RunningAsController"?
>>
>> The reasons to remove it are:
>> 1. It's currently broken.  The purpose of the JIRA
>> <https://issues.apache.org/jira/browse/KAFKA-3761> was to report that the
>> RunningAsController state gets overwritten back to "RunningAsBroker".
>> 2. It's not a useful state.
>>   a. If clients want to use this metric to know whether a broker is ready
>> to receive requests or not, they do not care whether or not the broker is
>> the controller
>>   b. there is already a separate boolean property, KafkaController.isActive
>> which contains this information.
>>
>> Thanks,
>>
>> Roger
>>

Re: [DISCUSS] KAFKA-3761: Controller has RunningAsBroker instead of RunningAsController state

Posted by Ismael Juma <is...@juma.me.uk>.

+1 from me.

Ismael

On Thu, Jun 23, 2016 at 11:57 PM, Roger Hoover <ro...@gmail.com>
wrote:

> Hi all,
>
> Does anyone have an issue with removing the broker state called
> "RunningAsController"?
>
> The reasons to remove it are:
> 1. It's currently broken.  The purpose of the JIRA
> <https://issues.apache.org/jira/browse/KAFKA-3761> was to report that the
> RunningAsController state gets overwritten back to "RunningAsBroker".
> 2. It's not a useful state.
>   a. If clients want to use this metric to know whether a broker is ready
> to receive requests or not, they do not care whether or not the broker is
> the controller
>   b. there is already a separate boolean property, KafkaController.isActive
> which contains this information.
>
> Thanks,
>
> Roger
>