You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/25 14:36:14 UTC
[GitHub] [maven] michael-o opened a new pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
michael-o opened a new pull request #641:
URL: https://github.com/apache/maven/pull/641
This closes #641
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1002965979
> @michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method
While you are absolutely right, this is not the target of this ticket OR I need to broaden the ticket and solve this for all derved types. I absolutely do not like the fact that `AbstractArtifact` lacks abstraction and uses `DefaultArtifact` internally.
Maybe: Mutating derived Artifact does not retain type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1002970252
> no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication
Agree, suboptimal.
> digging a little bit more, it requires a maven-resolver release, which makes the update harder from a release perspective
I guess we can make that for 2.0.0 happen. Maybe 1.8.0, unsure. @cstamas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1003047327
@hboutemy Any objections to merge this one and resolve in general with new issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #641:
URL: https://github.com/apache/maven/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1003048363
https://issues.apache.org/jira/browse/MRESOLVER-233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1002963399
@michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #641:
URL: https://github.com/apache/maven/pull/641#discussion_r775186215
##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
##########
@@ -86,6 +86,39 @@ public String getVersion()
}
}
+ @Override
+ public Artifact setVersion( String version )
+ {
+ String current = getVersion();
+ if ( current.equals( version ) || ( version == null && current.length() <= 0 ) )
Review comment:
While this is true, I wanted to retain the same code block as in `AbstractArtifact` for consistency reasons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] Marcono1234 commented on a change in pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
Marcono1234 commented on a change in pull request #641:
URL: https://github.com/apache/maven/pull/641#discussion_r775184928
##########
File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
##########
@@ -86,6 +86,39 @@ public String getVersion()
}
}
+ @Override
+ public Artifact setVersion( String version )
+ {
+ String current = getVersion();
+ if ( current.equals( version ) || ( version == null && current.length() <= 0 ) )
Review comment:
Could this be simplified?
```suggestion
if ( current.equals( version ) || ( version == null && current.isEmpty() ) )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit merged pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #641:
URL: https://github.com/apache/maven/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1003050980
@michael-o no problem to do the work in 2 steps, sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #641:
URL: https://github.com/apache/maven/pull/641#issuecomment-1002967160
no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication
digging a little bit more, it requires a maven-resolver release, which makes the update harder from a release perspective
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org