[jira] [Closed] (PDFBOX-4665) PDImageXObject createFromFileByExtension does not close FileInputStream in event of error

["Andreas Lehmkühler (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PDFBOX-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Lehmkühler closed PDFBOX-4665.
--------------------------------------

> PDImageXObject createFromFileByExtension does not close FileInputStream in event of error
> -----------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4665
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4665
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.0.17
>            Reporter: Chris Cockayne
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 2.0.18
>
>
> if you pass a mislabelled jpeg image file to PDImageXObject.createFromFileByExtension, e.g. a png image that is incorrectly named foo.jpg, then the file is treated as a JPEG. A FileInputStream is opened and JPEGFactory.createFromStream then (correctly) throws an IIOException. However, the FileInputStream is not closed.
> I saw that this is fixed in 3.0.0-SNAPSHOT:
> |if ("jpg".equals(ext) \|\| "jpeg".equals(ext))|
> |{|
> |try (FileInputStream fis = new FileInputStream(file))|
> |{
> return JPEGFactory.createFromStream(doc, fis);
> }|
> }
>  
> but if another 2.0.x release is made it would be good to include this.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org