You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Bryan Call (JIRA)" <ji...@apache.org> on 2010/02/25 21:54:28 UTC
[jira] Created: (TS-215) remove ink_*printf fucntions from
libinktomi++
remove ink_*printf fucntions from libinktomi++
----------------------------------------------
Key: TS-215
URL: https://issues.apache.org/jira/browse/TS-215
Project: Traffic Server
Issue Type: Improvement
Components: Cleanup
Reporter: Bryan Call
These function have become wrappers around vsnprintf and vsprintf and don't add functionality.
ink_snprintf, ink_sprintf, ink_vsnprintf, and ink_vsprintf
ink_fprintf and ink_vfprintf are just wrappers around vfprintf
ink_printf has become a wrapper around ink_vfprintf and can be removed too.
We can possible remove these too:
ink_bsprintf, ink_bvsprintf
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-215) remove ink_*printf fucntions from
libinktomi++
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Call reassigned TS-215:
-----------------------------
Assignee: Bryan Call
> remove ink_*printf fucntions from libinktomi++
> ----------------------------------------------
>
> Key: TS-215
> URL: https://issues.apache.org/jira/browse/TS-215
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup
> Reporter: Bryan Call
> Assignee: Bryan Call
> Fix For: 2.1.0
>
>
> These function have become wrappers around vsnprintf and vsprintf and don't add functionality.
> ink_snprintf, ink_sprintf, ink_vsnprintf, and ink_vsprintf
> ink_fprintf and ink_vfprintf are just wrappers around vfprintf
> ink_printf has become a wrapper around ink_vfprintf and can be removed too.
> We can possible remove these too:
> ink_bsprintf, ink_bvsprintf
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-215) remove ink_*printf fucntions from
libinktomi++
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-215:
-----------------------------
Fix Version/s: 2.1.0
> remove ink_*printf fucntions from libinktomi++
> ----------------------------------------------
>
> Key: TS-215
> URL: https://issues.apache.org/jira/browse/TS-215
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup
> Reporter: Bryan Call
> Fix For: 2.1.0
>
>
> These function have become wrappers around vsnprintf and vsprintf and don't add functionality.
> ink_snprintf, ink_sprintf, ink_vsnprintf, and ink_vsprintf
> ink_fprintf and ink_vfprintf are just wrappers around vfprintf
> ink_printf has become a wrapper around ink_vfprintf and can be removed too.
> We can possible remove these too:
> ink_bsprintf, ink_bvsprintf
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TS-215) remove ink_*printf fucntions from
libinktomi++
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Call updated TS-215:
--------------------------
Attachment: 001-printf-bcall.patch
Updates to remove ink_*printf functions.
We still need ink_bsprintf and ink_bvsprintf, because of:
Concerning the return value of snprintf(), SUSv2 and C99 contradict
each other: when snprintf() is called with size=0 then SUSv2 stipulates
an unspecified return value less than 1, while C99 allows str to be
NULL in this case, and gives the return value (as always) as the number
of characters that would have been written in case the output string
has been large enough.
We rely on passing a NULL to ink_bvsprintf and getting the size of the string we need to allocate. Not efficient, but this feature is used. I didn't know if OpenSolaris or other OSes follow the SUSv2 spec.
> remove ink_*printf fucntions from libinktomi++
> ----------------------------------------------
>
> Key: TS-215
> URL: https://issues.apache.org/jira/browse/TS-215
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup
> Reporter: Bryan Call
> Assignee: Bryan Call
> Fix For: 2.1.0
>
> Attachments: 001-printf-bcall.patch
>
>
> These function have become wrappers around vsnprintf and vsprintf and don't add functionality.
> ink_snprintf, ink_sprintf, ink_vsnprintf, and ink_vsprintf
> ink_fprintf and ink_vfprintf are just wrappers around vfprintf
> ink_printf has become a wrapper around ink_vfprintf and can be removed too.
> We can possible remove these too:
> ink_bsprintf, ink_bvsprintf
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.