You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 09:05:21 UTC

[GitHub] [arrow] niyue commented on a diff in pull request #13041: ARROW-16430: [Python] Add support for reading record batch custom metadata API

niyue commented on code in PR #13041:
URL: https://github.com/apache/arrow/pull/13041#discussion_r1011406639


##########
python/pyarrow/ipc.pxi:
##########
@@ -471,17 +471,22 @@ cdef class _CRecordBatchWriter(_Weakrefable):
         else:
             raise ValueError(type(table_or_batch))
 
-    def write_batch(self, RecordBatch batch):
+    def write_batch(self, RecordBatch batch, custom_metadata=None):
         """
         Write RecordBatch to stream.
 
         Parameters
         ----------
         batch : RecordBatch
+        custom_metadata : dict

Review Comment:
   I change it to `KeyValueMetadata` like other parts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org