You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Hussain Towaileb (Code Review)" <de...@asterixdb.apache.org> on 2019/06/13 14:47:46 UTC
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Hussain Towaileb has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3438
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
[NO ISSUE][FUN] round() remove unnecessary Math.abs()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Removed unnecessary Math.abs().
Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
---
M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/38/3438/1
diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
index c06fd35..11aa620 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
@@ -172,7 +172,7 @@
if (roundingDigit >= 0) {
// Multiplier based on round digit
- double multiplier = Math.pow(10, Math.abs(roundingDigit));
+ double multiplier = Math.pow(10, roundingDigit);
switch (valueTypeTag) {
// For zero and positive digit rounding, no need to do anything for integers
@@ -209,8 +209,8 @@
}
// Left of decimal (negative roundingDigit value)
else {
- // Multiplier based on round digit
- double multiplier = Math.pow(10, Math.abs(roundingDigit));
+ // Multiplier based on round digit (convert to positive digit)
+ double multiplier = Math.pow(10, -roundingDigit);
switch (valueTypeTag) {
case TINYINT:
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5928/ (2/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:47:55 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3936/ (5/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:47:57 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5950/ (9/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:03 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/868/ (7/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:00 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1106/ (13/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:10 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1295/ (16/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:53:47 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Hussain Towaileb (Code Review)" <de...@asterixdb.apache.org>.
Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:21:31 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6299/ (4/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:47:56 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5846/ (1/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:47:55 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Hussain Towaileb (Code Review)" <de...@asterixdb.apache.org>.
Hussain Towaileb has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
[NO ISSUE][FUN] round() remove unnecessary Math.abs()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Removed unnecessary Math.abs().
Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3438
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hu...@gmail.com>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
---
M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins: Verified; ; Verified
Hussain Towaileb: Looks good to me, but someone else must approve
Dmitry Lychagin: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
index c06fd35..11aa620 100644
--- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
+++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
@@ -172,7 +172,7 @@
if (roundingDigit >= 0) {
// Multiplier based on round digit
- double multiplier = Math.pow(10, Math.abs(roundingDigit));
+ double multiplier = Math.pow(10, roundingDigit);
switch (valueTypeTag) {
// For zero and positive digit rounding, no need to do anything for integers
@@ -209,8 +209,8 @@
}
// Left of decimal (negative roundingDigit value)
else {
- // Multiplier based on round digit
- double multiplier = Math.pow(10, Math.abs(roundingDigit));
+ // Multiplier based on round digit (convert to positive digit)
+ double multiplier = Math.pow(10, -roundingDigit);
switch (valueTypeTag) {
case TINYINT:
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 2
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Anon. E. Moose (Code Review)" <de...@asterixdb.apache.org>.
Anon. E. Moose (1000171) has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/CRdFsp9f3rtxXDwy7 : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:52:20 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1: Contrib+1
BAD Compatibility Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4541/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 15:08:16 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/707/ (3/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:47:55 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11419/ (10/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:05 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8705/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:04:51 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1201/ (14/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:12 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8705/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:55:02 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9885/ (12/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:09 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4541/
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:51:01 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6091/ (6/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:47:58 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6149/ (11/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:07 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5909/ (8/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:02 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Jenkins (Code Review)" <de...@asterixdb.apache.org>.
Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6510/ (15/16)
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 14:48:14 +0000
Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
Posted by "Dmitry Lychagin (Code Review)" <de...@asterixdb.apache.org>.
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Hussain Towaileb <hu...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:36:49 +0000
Gerrit-HasComments: No