Re: [patch] s/...->trace/info

[Doug MacEachern <do...@covalent.net>]

On Mon, 31 Dec 2001, Stas Bekman wrote:

> Currently there are two tracing mechanisms used in Apache::Test, the
> on/off turning if which is not consistent. This patch replaces the ->trace
> calls with Apache::TestTrace::info().
> 
> This patch makes things consistent through using the Apache::TestTrace log
> levels.
> 
> I suppose that by default the "log" level should be 'warning' and TestRun
> should change the loglevel to 'info' if called with -verbose. Because
> with this patch there is too much noise (since 'info' is the default log
> level).

how about changing those to 'debug', and set the log level to debug if
verbose is on?  i don't think the current 'info' output is to noisy.

Re: [patch] s/...->trace/info

[Doug MacEachern <do...@covalent.net>]

On Sun, 6 Jan 2002, Stas Bekman wrote:
> 
> That's not very good, because sometimes you want to -v to see all the 
> configure tracing, but in most cases we use -v for verbose testing 
> output, where we don't want any extra noise, but the debug prints from 
> the tests.

ok.
 
> > i don't think the current 'info' output is to noisy.
> 
> So should I commit it as is?

i meant current before the patch.  +1 if you just change s/info/debug/g in
your patch.

Re: [patch] s/...->trace/info

[Stas Bekman <st...@stason.org>]

Doug MacEachern wrote:

> On Mon, 31 Dec 2001, Stas Bekman wrote:
> 
> 
>>Currently there are two tracing mechanisms used in Apache::Test, the
>>on/off turning if which is not consistent. This patch replaces the ->trace
>>calls with Apache::TestTrace::info().
>>
>>This patch makes things consistent through using the Apache::TestTrace log
>>levels.
>>
>>I suppose that by default the "log" level should be 'warning' and TestRun
>>should change the loglevel to 'info' if called with -verbose. Because
>>with this patch there is too much noise (since 'info' is the default log
>>level).
>>
> 
> how about changing those to 'debug', and set the log level to debug if
> verbose is on?  


That's not very good, because sometimes you want to -v to see all the 
configure tracing, but in most cases we use -v for verbose testing 
output, where we don't want any extra noise, but the debug prints from 
the tests.

> i don't think the current 'info' output is to noisy.

So should I commit it as is?

_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:stas@stason.org  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/