You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/02/03 14:25:28 UTC
[GitHub] [pulsar] roman-popenov opened a new pull request #6191:
[Issue-6143][helm]: Add the rbac policy to give the brokers permissions to
deploy functions
roman-popenov opened a new pull request #6191: [Issue-6143][helm]: Add the rbac policy to give the brokers permissions to deploy functions
URL: https://github.com/apache/pulsar/pull/6191
### Motivation
Fixes feature enhancement request #6143:
Currently, there are quite a few undocumented steps that are needed to be performed manually in order to make sure that the functions can be submitted as pods in K8s runtime environment. It would be much better if this process would be automated.
#### Proposed solution:
Automate this process via helm install and update the helm charts with templates.
### Modifications
I've added an additional `functionsAsPods` filed in extra components inside the values file. If the setting is set to `yes`, then it would add `serviceAccount` to the broker deployment. It will also add the rbac policy to give the brokers permissions to deploy functions. The policies can be found in the new `broker-rbac.yaml` template file. Moreover, it will also change the `functions_worker` settings and set the function runtime factory setting that can be found inside `broker-configmap.yaml`.
### Verifying this change
1) Set `functionsAsPods: yes` inside helm values yaml file.
2) Follow the instructions on how deploying helm and run:
`helm install pulsar --values pulsar/values-mini.yaml ./pulsar/`.
3) Wait until all the services are up and running.
4) Set up tenant, namespace.
5) Create a function, sink and source and submit it using the CLI to make sure the pods are running alongside the Pulsar cluster. In addition, set up such a flow where the data is flowing from source to topics, the processed by a function and sink outputs the data
6) Push data into cluster through the source and make sure it comes out of the sink into destination. There shouldn't be any errors in the logs of brokers, bookie, sources, sinks and functions.
#### Modules affected:
The changes in the PR are affecting the deployment using the helm charts. Now the if the flag `functionsAsPods` is set to `yes` inside the `values.yaml. file, the functions would run as pods.
### Documentation
Currently, the documentations explaining the helm chart deployment process is lacking and this should be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6191: [Issue-6143][helm]: Add
the rbac policy to give the brokers permissions to deploy functions
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6191: [Issue-6143][helm]: Add the rbac policy to give the brokers permissions to deploy functions
URL: https://github.com/apache/pulsar/pull/6191#issuecomment-583214026
Thanks @roman-popenov for the help. @sijie @wolfstudy to help review it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie merged pull request #6191: [Issue-6143][helm]: Add
the rbac policy to give the brokers permissions to deploy functions
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6191: [Issue-6143][helm]: Add the rbac policy to give the brokers permissions to deploy functions
URL: https://github.com/apache/pulsar/pull/6191
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] softstuff commented on issue #6191: [Issue-6143][helm]:
Add the rbac policy to give the brokers permissions to deploy functions
Posted by GitBox <gi...@apache.org>.
softstuff commented on issue #6191: [Issue-6143][helm]: Add the rbac policy to give the brokers permissions to deploy functions
URL: https://github.com/apache/pulsar/pull/6191#issuecomment-604594062
Hi, some blame game ;) you messed up broker-configmap.yaml by adding two spaces first on row 47. The generate yaml is now invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services