[GitHub] [druid] FrankChen021 commented on a diff in pull request #13045: fix bug in /status/properties filtering

[GitBox <gi...@apache.org>]

FrankChen021 commented on code in PR #13045:
URL: https://github.com/apache/druid/pull/13045#discussion_r964876401


##########
server/src/test/java/org/apache/druid/server/StatusResourceTest.java:
##########
@@ -85,7 +85,11 @@ private void testHiddenPropertiesWithPropertyFileName(String fileName)
                                                            .map(StringUtils::toLowerCase)
                                                            .collect(Collectors.toSet());
     Set<String> hiddenProperties = new HashSet<>();
-    Splitter.on(",").split(returnedProperties.get("druid.server.hiddenProperties")).forEach(hiddenProperties::add);
+    String hiddenPropertiesString = returnedProperties.get("druid.server.hiddenProperties")

Review Comment:
   I'm wondering if we can use jackson to deserialize the `hiddenPropertiesString` to a String array or set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org