You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/12 17:12:06 UTC
[GitHub] [flink] rmetzger opened a new pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
rmetzger opened a new pull request #13599:
URL: https://github.com/apache/flink/pull/13599
## What is the purpose of the change
Building Flink with Maven 3.3+ will fail, because the enforcer plugin detects banned dependencies. These dependencies are removed by shading, but since the dependency tree is immutable in these versions, the maven enforcer plugin won't see these removals.
## Brief change log
- Move the dependency ban into the release profile.
## Verifying this change
Manually verified locally with Maven 3.6.3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
}, {
"hash" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466)
* a419bd7f170482789f5e3c0bb0d279cc9fdf8244 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
}, {
"hash" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622",
"triggerID" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"triggerType" : "PUSH"
}, {
"hash" : "99473f1479ee093fb6cd90f5fd50665fa7c68261",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "99473f1479ee093fb6cd90f5fd50665fa7c68261",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a419bd7f170482789f5e3c0bb0d279cc9fdf8244 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622)
* 99473f1479ee093fb6cd90f5fd50665fa7c68261 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707637050
How about introducing a profile that activates automatically if the maven version is 3.2x? Then it would run on CI, in the release profile and in proper local setups? (I could add a comment that people need to use maven 3.2.5 for this ban to be active. That should be sufficient for tracing back the issue from a CI failure to reproducing it locally?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707243781
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 99473f1479ee093fb6cd90f5fd50665fa7c68261 (Fri Oct 16 10:57:40 UTC 2020)
**Warnings:**
* **8 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
}, {
"hash" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622",
"triggerID" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466)
* a419bd7f170482789f5e3c0bb0d279cc9fdf8244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13599:
URL: https://github.com/apache/flink/pull/13599#discussion_r505384695
##########
File path: pom.xml
##########
@@ -818,6 +818,11 @@ under the License.
<artifactId>disruptor</artifactId>
<version>3.4.2</version>
</dependency>
+ <dependency>
+ <groupId>org.yaml</groupId>
+ <artifactId>snakeyaml</artifactId>
Review comment:
should we now be able to remove some depMgmt entries from other modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707243781
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c (Mon Oct 12 17:13:59 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-708450393
Thanks a lot for the review. I've added snakeyaml to the dependencyManagement section of the root pom, which makes the build pass locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-709963619
Thanks a lot. Merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
}, {
"hash" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622",
"triggerID" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"triggerType" : "PUSH"
}, {
"hash" : "99473f1479ee093fb6cd90f5fd50665fa7c68261",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7700",
"triggerID" : "99473f1479ee093fb6cd90f5fd50665fa7c68261",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99473f1479ee093fb6cd90f5fd50665fa7c68261 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
}, {
"hash" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622",
"triggerID" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"triggerType" : "PUSH"
}, {
"hash" : "99473f1479ee093fb6cd90f5fd50665fa7c68261",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7700",
"triggerID" : "99473f1479ee093fb6cd90f5fd50665fa7c68261",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a419bd7f170482789f5e3c0bb0d279cc9fdf8244 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622)
* 99473f1479ee093fb6cd90f5fd50665fa7c68261 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707797401
That's definitely _better_, but we're still just fighting symptoms.
The underlying problem isn't shading, but dependency management (annoyingly) not being visible to consumers of a module. So when flink-dist comes around it sees the original transitive dependencies. If we were to explicitly declare dependencies on snakeyaml in the modules that currently use dependency management this problem would also go away, but there are also downsides since it obfuscates the dependency tree which is really annoying.
Essentially, dependency management should be defined where they cover all relevant modules and consumers, which for us, in the case of flink-dist, is unfortunately the root pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707797401
That's definitelx _better_, but we're still just fighting symptoms.
The underlying problem isn't shading, but dependency management (annoyingly) not being visible to consumers of a module. So when flink-dist comes around it sees the original transitive dependencies. If we were to explicitly declare dependencies on snakeyaml in the modules that currently use dependency management this problem would also go away, but there are also downsides since it obfuscates the dependency tree which is really annoying.
Essentially, dependency management should be defined where they cover all relevant modules and consumers, which for us, in the case of flink-dist, is unfortunately the root pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
}, {
"hash" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622",
"triggerID" : "a419bd7f170482789f5e3c0bb0d279cc9fdf8244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a419bd7f170482789f5e3c0bb0d279cc9fdf8244 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7622)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7466)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-707258177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a27e9f8f969a07b285bc0a35504e7e2ba3f7ab7c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13599:
URL: https://github.com/apache/flink/pull/13599
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-708450629
I am aware of the weird commit history, which will be fixed before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13599: [FLINK-19459] Run certain maven-enforcer-plugin executions only in release profile
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13599:
URL: https://github.com/apache/flink/pull/13599#issuecomment-709561937
I'm sorry that I didn't check better for other dependency management sections for snakeyaml.
With this change, the build still passes with newer maven versions.
I believe the NOTICE files will remain correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org