You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/27 12:50:38 UTC
[GitHub] [rocketmq] HaoTianZhao opened a new issue #2046: selectOneMessageQueue must select lastFailBroker
HaoTianZhao opened a new issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046
branch 4.7.0
class MQFaultStrategy
row 72
if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))
it should be:
if (null == lastBrokerName || !mq.getBrokerName().equals(lastBrokerName))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ifplusor commented on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
ifplusor commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-635064242
```latencyFaultTolerance.isAvailable(mq.getBrokerName())``` has checked the availability of the mq. ```null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName)``` is redundant, and cause a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] HaoTianZhao commented on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
HaoTianZhao commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-634638258
selectOneMessageQueue must select lastFailBroker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] HaoTianZhao commented on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
HaoTianZhao commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-634666702
> > branch 4.7.0
> > class MQFaultStrategy
> > row 68
> > if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))
> > it should be:
> > if (null == lastBrokerName || !mq.getBrokerName().equals(lastBrokerName))
>
> As you say, if lastBrokerName is null, it will select one MessageQueue, assuming MessageQueue-a. If it occurs some exception while producing to MessageQueue-a, it will always select MessageQueue-a since then. Can you submit a pr to fix it?
of course
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
lizhiboo commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-634652299
> branch 4.7.0
> class MQFaultStrategy
> row 68
> if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))
> it should be:
> if (null == lastBrokerName || !mq.getBrokerName().equals(lastBrokerName))
As you say, if lastBrokerName is null, it will select one MessageQueue, assuming MessageQueue-a. If it occurs some exception while producing to MessageQueue-a, it will always select MessageQueue-a since then. Can you submit a pr to fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ifplusor commented on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
ifplusor commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-635059357
See #1607
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] HaoTianZhao removed a comment on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
HaoTianZhao removed a comment on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-634638258
selectOneMessageQueue must select lastFailBroker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ifplusor commented on issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
ifplusor commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-635055354
Same as #1576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #2046: selectOneMessageQueue must select lastFailBroker
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org