You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Lars Francke (JIRA)" <ji...@apache.org> on 2011/03/14 12:17:29 UTC
[jira] Created: (THRIFT-1090) Document the generation of a file
called "Constants.java"
Document the generation of a file called "Constants.java"
---------------------------------------------------------
Key: THRIFT-1090
URL: https://issues.apache.org/jira/browse/THRIFT-1090
Project: Thrift
Issue Type: Improvement
Components: Java - Library, Website
Reporter: Lars Francke
Priority: Minor
A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
(there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Riley updated THRIFT-1090:
-------------------------------
Patch Info: Patch Available
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Jake Farrell (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1090.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.9
Assignee: Mike Riley
Committed, thanks Mike
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Jake Farrell (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1090.
--------------------------------
Resolution: Fixed
Fixed
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Riley updated THRIFT-1090:
-------------------------------
Attachment: thrift-1090.patch
My changes didn't need to be rebased from 0.70 so I included the patch here.
Again, might not be optimal for everyone but it works.
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Improvement
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-1090:
--------------------------------
Component/s: Documentation
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Improvement
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Jake Farrell (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell reopened THRIFT-1090:
----------------------------------
Patch did not take into account test cases that used Constants file
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163314#comment-13163314 ]
Jake Farrell commented on THRIFT-1090:
--------------------------------------
I all ready committed a fix, ran locally and now running against ci to verify
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163326#comment-13163326 ]
Hudson commented on THRIFT-1090:
--------------------------------
Integrated in Thrift #350 (See [https://builds.apache.org/job/Thrift/350/])
Thrift-1090: Document the generation of a file called "Constants.java"
Client: java
Patch: Jake Farrell
Fixing test cases left out in initial patch.
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163306#comment-13163306 ]
Mike Riley commented on THRIFT-1090:
------------------------------------
Reverted? Do you need me to fix that?
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153446#comment-13153446 ]
Mike Riley commented on THRIFT-1090:
------------------------------------
I think really instead of documentation the Java generator shouldn't be clobbering constants defined in separate thrift files.
To the best of my understanding, most users are defining all constants in one file for each namespace so this doesn't become an issue. Documented or not, it still doesn't seem like a reasonable constraint for how you're allowed to define constants.
I have this patched in my local copy to just generate a separate .java file containing constants for each program (.thrift file) that contains them. This might not be an ideal solution for everyone but it's how I worked around it.
Any other suggestions?
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Improvement
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158064#comment-13158064 ]
Mike Riley commented on THRIFT-1090:
------------------------------------
I'm going to reclassify this as a bug so that it can hopefully get some visibility.
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Improvement
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Bryan Duxbury (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158637#comment-13158637 ]
Bryan Duxbury commented on THRIFT-1090:
---------------------------------------
This seems like it could be an OK change, though it's important to note that it will break stuff for people using it (since we're changing the class name). Anyone else have an objection to applying this?
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161403#comment-13161403 ]
Mike Riley commented on THRIFT-1090:
------------------------------------
Should I re-implement this as a language option? From my perspective this is an inconsistency that Java has when compared to the other languages: constants can't be defined in different programs having the same namespace. On the other hand, if there is a consensus that it should be added as an option it wouldn't be so difficult to implement.
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158692#comment-13158692 ]
Mike Riley commented on THRIFT-1090:
------------------------------------
PHP, C++ and Javascript (can't speak for any other languages) already organize constants on a per-program and a per-namespace basis. Cocoa organizes on a per-program basis only because it doesn't have namespaces. Java seems to be the odd man out in organizing per-namespace only.
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158679#comment-13158679 ]
Jake Farrell commented on THRIFT-1090:
--------------------------------------
Would we be porting this to all other libs? If this is just for java then we should make it optional rather than the default
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Mike Riley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Riley updated THRIFT-1090:
-------------------------------
Issue Type: Bug (was: Improvement)
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Priority: Minor
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1090) Document the generation of a file
called "Constants.java"
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163250#comment-13163250 ]
Hudson commented on THRIFT-1090:
--------------------------------
Integrated in Thrift #347 (See [https://builds.apache.org/job/Thrift/347/])
Thrift-1090: Document the generation of a file called "Constants.java"
Client: java
Patch: Mike Riley
Adds program_name to the Constants file in java to match all other client libs.
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
> Key: THRIFT-1090
> URL: https://issues.apache.org/jira/browse/THRIFT-1090
> Project: Thrift
> Issue Type: Bug
> Components: Documentation, Java - Library, Website
> Reporter: Lars Francke
> Assignee: Mike Riley
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-1090.patch
>
>
> A file called "Constants.java" is generated per thrift file that includes any constants. This should be documented somewhere because if you have multiple thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira