You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andi Huber (Jira)" <ji...@apache.org> on 2022/11/30 06:23:00 UTC
[jira] [Updated] (WICKET-7019) Remove Junit Jupiter from module path (JPMS)
[ https://issues.apache.org/jira/browse/WICKET-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andi Huber updated WICKET-7019:
-------------------------------
Description:
With Wicket Core's WicketTester on the module path, consuming projects that also use JPMS are forced to change their junit-jupiter-engine dependency scopes from 'test' to 'compile' (Maven speak.) Which in our case does break corresponding surefire tests no matter what.
So the desired solution would be to split out WicketTester from wicket-core into wicket-core-tester say and don't put that artifact on the module path, use an automated module name instead.
As a proof of concept, I forked off on Wicket 10.0.0-M1-SNAPSHOT, kept everything on the module path as is, just removing Jupiter, hence had to split out WicketTester into its own artifact. And also split up wicket-util into 2 artifacts. But thats it.
For reference the fork can be found here https://github.com/apache-causeway-committers/wicket. (Its stripped off the artifacts we don't care about. So not a merge candidate, but to show it can be done.)
was:
With Wicket Core's WicketTester on the module path, consuming projects that also use JPMS are forced to change their junit-jupiter-engine dependency scopes from 'test' to 'compile' (Maven speak.) Which in our case does break corresponding surefire tests no matter what.
So the desired solution would be to split out WicketTester from wicket-core into wicket-core-tester say and don't put that artifact on the module path, use an automated module name instead.
As I proof of concept, I forked off on Wicket 10.0.0-M1-SNAPSHOT, kept everything on the module path as is, just removing Jupiter, hence had to split out WicketTester into its own artifact. And also split up wicket-util into 2 artifacts. But thats it.
For reference the fork can be found here https://github.com/apache-causeway-committers/wicket. (Its stripped off the artifacts we don't care about. So not a merge candidate, but to show it can be done.)
> Remove Junit Jupiter from module path (JPMS)
> --------------------------------------------
>
> Key: WICKET-7019
> URL: https://issues.apache.org/jira/browse/WICKET-7019
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 10.0.0
> Reporter: Andi Huber
> Priority: Major
>
> With Wicket Core's WicketTester on the module path, consuming projects that also use JPMS are forced to change their junit-jupiter-engine dependency scopes from 'test' to 'compile' (Maven speak.) Which in our case does break corresponding surefire tests no matter what.
> So the desired solution would be to split out WicketTester from wicket-core into wicket-core-tester say and don't put that artifact on the module path, use an automated module name instead.
> As a proof of concept, I forked off on Wicket 10.0.0-M1-SNAPSHOT, kept everything on the module path as is, just removing Jupiter, hence had to split out WicketTester into its own artifact. And also split up wicket-util into 2 artifacts. But thats it.
> For reference the fork can be found here https://github.com/apache-causeway-committers/wicket. (Its stripped off the artifacts we don't care about. So not a merge candidate, but to show it can be done.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)